Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Heightmap, HeightmapBlend and HeightmapTexture Python interfaces #993

Merged
merged 6 commits into from
Jun 9, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 20, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

This PR is part of this mete ticket #931

Summary

Added Heightmap, HeightmapBlend, HeightmapTexture Python interfaces

Test it

from sdformat import Heightmap, HeightmapBlend, HeightmapTexture

heightmap = Heightmap()
heightmapBlend = HeightmapBlend()
heightmapTexture = HeightmapTexture()

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added scripting Scripting interfaces to Ignition mujoco labels Apr 20, 2022
@ahcorde ahcorde self-assigned this Apr 20, 2022
@ahcorde ahcorde mentioned this pull request Apr 20, 2022
62 tasks
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 20, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Apr 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #993 (9b83bb4) into main (7baa3ee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #993   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           2        2           
  Lines          27       27           
=======================================
  Hits           18       18           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7baa3ee...9b83bb4. Read the comment docs.

@chapulina chapulina moved this from Inbox to In review in Core development Apr 22, 2022
@j-rivero j-rivero removed this from In review in Core development May 6, 2022
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #993 (dc2269e) into main (5f3031e) will decrease coverage by 0.11%.
The diff coverage is 61.70%.

@@            Coverage Diff             @@
##             main     #993      +/-   ##
==========================================
- Coverage   83.64%   83.53%   -0.12%     
==========================================
  Files         146      147       +1     
  Lines       18255    18349      +94     
==========================================
+ Hits        15269    15327      +58     
- Misses       2986     3022      +36     
Impacted Files Coverage Δ
python/src/sdf/pyHeightmap.cc 60.43% <60.43%> (ø)
python/src/sdf/_ignition_sdformat_pybind11.cc 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f3031e...dc2269e. Read the comment docs.

@chapulina chapulina added this to Inbox in Core development via automation Jun 2, 2022
@chapulina chapulina moved this from Inbox to In review in Core development Jun 2, 2022
@ahcorde ahcorde merged commit 094e7a2 into main Jun 9, 2022
@ahcorde ahcorde deleted the ahcorde/python/heightmap branch June 9, 2022 15:11
Core development automation moved this from In review to Done Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden mujoco scripting Scripting interfaces to Ignition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants