Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accomodate out-of-repo builds #523

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Accomodate out-of-repo builds #523

merged 1 commit into from
Dec 18, 2023

Conversation

ISSOtm
Copy link
Member

@ISSOtm ISSOtm commented Dec 17, 2023

Fix #514, cc @mid-kid for the interface/behaviour.

@ISSOtm ISSOtm added the mdbook label Dec 17, 2023
@mid-kid
Copy link

mid-kid commented Dec 17, 2023

Sounds good to me! What would the correct invocation of mdbook build be?

@ISSOtm
Copy link
Member Author

ISSOtm commented Dec 17, 2023

Hopefully you're able to figure that out on your own? (This is not a taunt, but rather I tried to make this reasonably easy for other packagers who may not be able to ask us for help, and I want to check that.)

@mid-kid
Copy link

mid-kid commented Dec 18, 2023

If I got this right, it's MDBOOK_preprocessor__pandocs__out_of_repo=true mdbook build?

@ISSOtm
Copy link
Member Author

ISSOtm commented Dec 18, 2023

Yep, that matches my understanding. Hopefully both of us are correct :D

Should we merge this, then?

@mid-kid
Copy link

mid-kid commented Dec 18, 2023

Yeah, 👍

@ISSOtm ISSOtm merged commit ec7d35d into gbdev:master Dec 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow building out-of-tree
3 participants