-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change in behaviour for jr @+constant #259
Comments
No, that's not intentional. |
Anecdotally, I also noticed that |
What game? |
I was testing while writing homebrew. I thought it was my fault though and it wasn't critical so I just ignored it. |
This is actually quite bad, it doesn't even work with constants. It only works when the result has to be calculated by the linker (labels, for example). In short, it works pretty much always, except when using I'll fix it and add it to the release notes of 0.3.6. I don't think that many people will be affected, though. |
Thanks Antonio. In my disassembler I generate these type of instructions when there is a |
I've found a problem when fixing this.
I can only fix one of the 2 groups with the current code, so I'll have to do some more serious modifications to it... |
Perhaps while you're fixing this, you can allow While disassembling, I frequently find myself wanting to write placeholders like |
The problem is that The crash with constants is another issue, and that is easy to fix. |
I've created a pull request that should take care of both problems. |
Source:
In 0.3.5 this is assembled as these bytes:
In 0.3.6 this is assembled as these bytes:
Is this an intentional change? I'm guessing its related to the "Allow JR between sections." change in 0.3.6.
The text was updated successfully, but these errors were encountered: