Allow padding to coexist with overlay file #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
added
enhancement
ISSOtm
previously requested changes
May 15, 2024
ISSOtm
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows RGBLINK
-pand-Oto coexist. If fixed sections are declared that cover space beyond the overlay file, they may need to be filled with padding. Previously this padding was 0xFF, not intentionally, but becausegetc(overlayFile)was returningEOFand that-1value was being treated as unsigned.Since checking for when the overlay file is finished makes the exact-bank-size checks not technically necessary, those have been downgraded from errors to warnings.
Fixes #1394.