Skip to content

Commit

Permalink
Remove BR2_DEPRECATED
Browse files Browse the repository at this point in the history
The BR2_DEPRECATED logic is a lot less useful than the legacy handling,
because the symbols just disappears without warning to the user. For
example, we had a few defconfigs that were using deprecated symbols
(which were not actually used because BR2_DEPRECATED wasn't set) so
these didn't build the expected code anymore.

Also, the idea behind BR2_DEPRECATED is that you can easily revive it
again if there is interest. However, it is relatively easy to revert
the removal of a package as well.

The deprecation is also more effort because it has to be removed twice:
once when deprecating, and once when really removing.

It doesn't make sense to add a legacy entry for BR2_DEPRECATED. Users
who actually used it will get legacy warnings instead.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
  • Loading branch information
arnout authored and jacmet committed Oct 15, 2016
1 parent 3534399 commit 49315f2
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 35 deletions.
30 changes: 0 additions & 30 deletions Config.in
Expand Up @@ -361,36 +361,6 @@ config BR2_CCACHE_USE_BASEDIR

endif

config BR2_DEPRECATED
bool "Show options and packages that are deprecated or obsolete"
help
This option shows outdated/obsolete versions of packages and
options that are otherwise hidden.

if BR2_DEPRECATED

config BR2_DEPRECATED_SINCE_2015_11
bool
default y

config BR2_DEPRECATED_SINCE_2016_02
bool
default y

config BR2_DEPRECATED_SINCE_2016_05
bool
default y

config BR2_DEPRECATED_SINCE_2016_08
bool
default y

config BR2_DEPRECATED_SINCE_2016_11
bool
default y

endif

config BR2_ENABLE_DEBUG
bool "build packages with debugging symbols"
help
Expand Down
2 changes: 0 additions & 2 deletions Makefile
Expand Up @@ -436,9 +436,7 @@ all: world

# Include legacy before the other things, because package .mk files
# may rely on it.
ifneq ($(BR2_DEPRECATED),y)
include Makefile.legacy
endif

include package/Makefile.in
include support/dependencies/dependencies.mk
Expand Down
3 changes: 0 additions & 3 deletions Makefile.legacy
Expand Up @@ -4,9 +4,6 @@
# This file contains placeholders to detect backward-compatibility problems.
# When a buildroot "API" feature is being deprecated, a rule should be added
# here that issues an error when the old feature is used.
#
# This file is not included if BR2_DEPRECATED is selected, so it is possible
# to bypass the errors (although that's usually a bad idea).

ifeq ($(BR2_LEGACY),y)
$(error "You have legacy configuration in your .config! Please check your configuration.")
Expand Down

0 comments on commit 49315f2

Please sign in to comment.