Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hide iframe scrollbars #12

Closed
nbremer opened this issue Apr 26, 2019 · 1 comment
Closed

Add option to hide iframe scrollbars #12

nbremer opened this issue Apr 26, 2019 · 1 comment

Comments

@nbremer
Copy link

nbremer commented Apr 26, 2019

Using a background visualization that is set to use the entire window creates scrollbars in the iframe for me because it's just a little too wide and high then, which I don't want to see. (Maybe it comes from using the external plugin as well?) Could there perhaps be an option that sets the scrolling="no" attribute on the iframe?

(I've now implemented a simple data-scroll extra option in the local copy I have of the reveald3.js code, which works, but I thought it might be a nice addition generally :) )

@gcalmettes gcalmettes mentioned this issue Apr 26, 2019
@gcalmettes
Copy link
Owner

Hey @nbremer!

Thanks for the suggestion! A new data-scroll optional attribute has been added (See merged PR #13). It is set to yes by default.

I have updated the documentation with a new advanced configuration section, and I have added a slide in the demo deck showing the data-scroll='no' in action.

Let me know if you need any other options or things that should be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants