Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for -std=c++17 & -std=c++2a flag #99

Merged
merged 1 commit into from
Aug 19, 2018

Conversation

praetorian20
Copy link
Contributor

gcc/clang C++ standard version flags now support the -std=c++17 &
-std=c++2a flags, along with their "gnu" counterparts.

@coveralls
Copy link

coveralls commented Jul 7, 2018

Coverage Status

Coverage decreased (-0.1%) to 92.638% when pulling 417add6 on praetorian20:develop into 87b4e12 on gccxml:develop.

@praetorian20
Copy link
Contributor Author

The travis-ci failure is due to a setup issue, not the code change.

@iMichka
Copy link
Contributor

iMichka commented Jul 13, 2018

The patch looks good. I am working on fixing the CI here: #98. Once this is done I'll have a closer look to your changes :)

@praetorian20
Copy link
Contributor Author

Thanks. I added some new is_cxx* functions but I don't think any other than is_cxx11* are actually used. So if you want I can delete the rest.

@iMichka
Copy link
Contributor

iMichka commented Jul 14, 2018

I fixed the CI, you can rebase and force push this.

@iMichka iMichka self-assigned this Jul 14, 2018
@praetorian20 praetorian20 force-pushed the develop branch 2 times, most recently from bc8a993 to 34607ec Compare July 15, 2018 20:19
@praetorian20
Copy link
Contributor Author

I deleted all the unused is_cxx* functions. Let me know if that's OK, I can add them back in if you prefer.

@praetorian20
Copy link
Contributor Author

@iMichka, sorry to bother you, but if the patch looks OK, would you please consider merging and creating a release? It would save me the trouble of having to patch pygccxml locally.

@praetorian20
Copy link
Contributor Author

Hi @iMichka, any update on this?

@iMichka
Copy link
Contributor

iMichka commented Aug 18, 2018

Hey, really sorry, got stuck with other projects. I really need to find more time to work on this next pygccxml release.

Could you add the is_cxx* functions back? They may not be used inside pygccxml, but they are not part of the API and somebody may have used them. If we want to remove them, they need to go through a deprecation cycle (with a deprecation warning in 2.0.0, and a removal in 2.1.0).

So please just add them back, thanks. Once this is done I will merge this right away.

gcc/clang C++ standard version flags now support the -std=c++17 &
-std=c++2a flags, along with their "gnu" counterparts.

Unused `is_cxx*` functions have been deleted.
@praetorian20
Copy link
Contributor Author

Done, added the functions back. I haven't added new is_cxx17 and is_cxx2a` functions because it would be nice to get rid of all the unused ones at some point.

@iMichka iMichka merged commit 2b1efbb into CastXML:develop Aug 19, 2018
@iMichka
Copy link
Contributor

iMichka commented Aug 19, 2018

Thanks @praetorian20. I will be on vacation and without internet connection during the 2 next weeks. I hope I can work a little bit on pygccxml soon so that I can get this 2.0.0 release out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants