Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FederatedStore RemoveGraphDeleteAccumuloTableHandler #2632

Closed
GCHQDev404 opened this issue Apr 21, 2022 · 2 comments · Fixed by #2799
Closed

FederatedStore RemoveGraphDeleteAccumuloTableHandler #2632

GCHQDev404 opened this issue Apr 21, 2022 · 2 comments · Fixed by #2799
Assignees
@GCHQDev404
Labels
enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module
Milestone
v2.0.0-alpha-0.4

Comments

@GCHQDev404
Copy link
Contributor

GCHQDev404 commented Apr 21, 2022 •
edited
Loading

Handler to force Accumulo to drop the table.

Update!

  • New Federated Operation: RemoveAndDeleteGraph
  • New Federated Handler: RemovAndDeleteGraphHandler
    -- extend RemoveGraphHandler.
    -- Before executing super.doOperation(), each graph is asked if it supports TearDownOperation
    -- If true sends TearDownOperation
    -- then executes super.doOperation()
  • New Operation: DeleteDataOperation
  • New Handler: DeleteDataHandler
    -- AccumuloStore implements this handler to do Accumulo specific drop tables.
    -- MapStore implements a token gesture of clear map (MapStore data deleted anyway when mapstore is removed and scope is lost)
@GCHQDev404 GCHQDev404 self-assigned this Apr 21, 2022
GCHQDev404 added a commit that referenced this issue Apr 22, 2022
@GCHQDev404
gh-2632 FederatedStore Remove Graph and Delete Accumulo table.
cf0d1fd
GCHQDev404 added a commit that referenced this issue Apr 22, 2022
@GCHQDev404
gh-2632 FederatedStore Remove Graph and Delete Accumulo table.
9b8845e
GCHQDev404 added a commit that referenced this issue Apr 22, 2022
@GCHQDev404
gh-2632 FederatedStore Remove Graph and Delete Accumulo table.
dedd3eb
GCHQDev404 added a commit that referenced this issue Apr 22, 2022
@GCHQDev404
gh-2632 FederatedStore Remove Graph and Delete Accumulo table.
ef05397
GCHQDev404 added a commit that referenced this issue Apr 22, 2022
@GCHQDev404
gh-2632 FederatedStore Remove Graph and Delete Accumulo table.
7772917
GCHQDev404 added a commit that referenced this issue Apr 23, 2022
@GCHQDev404
gh-2632 FederatedStore Remove Graph and Delete Accumulo table.
23aaac5
GCHQDev404 added a commit that referenced this issue Apr 23, 2022
@GCHQDev404
gh-2632 FederatedStore Remove Graph and Delete Accumulo table.
f893181
GCHQDev404 added a commit that referenced this issue Apr 23, 2022
@GCHQDev404
gh-2632 FederatedStore Remove Graph and Delete Accumulo table. Error …
dde43d7 
…improvement.
@n3101 n3101 added the federated-store Specific to/touches the federated-store module label Oct 12, 2022
@n3101 n3101 added this to the v2.0.0-alpha-0.5 milestone Oct 12, 2022
GCHQDev404 added a commit that referenced this issue Oct 23, 2022
@GCHQDev404
gh-2632 FederatedStore added FederatedRemoveGraphAndDeleteAccumuloTab…
617f2f7 
…leHandler
@GCHQDev404
Copy link
Contributor Author

This handler will require MANUAL testing against an Accumulo instance.
Remember to add the Handler to the FederatedStore config.

@github-actions github-actions bot mentioned this issue Oct 23, 2022
Closed
GCHQDev404 added a commit that referenced this issue Oct 23, 2022
@GCHQDev404
gh-2632 FederatedStore added FederatedRemoveGraphAndDeleteAccumuloTab…
a17f039 
…leHandler
GCHQDev404 added a commit that referenced this issue Oct 23, 2022
@GCHQDev404
Merge branch 'gh-2630-example-real-federatedstore' into gh-2632-feder…
f45d28b 
…atedstore-delete-accumulo-table

# Conflicts:
#	example/federated-demo/src/main/resources/operationDeclarations.json
#	store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/FederatedGraphStorage.java
#	store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/util/FederatedStoreUtil.java
GCHQDev404 added a commit that referenced this issue Oct 23, 2022
@GCHQDev404
Merge branch 'gh-2632-FederatedStore-RemoveGraphAndDeleteAccumuloTabl…
8e1fc24 
…e' into gh-2632-federatedstore-delete-accumulo-table

# Conflicts:
#	store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/operation/handler/impl/FederatedRemoveGraphDeleteAccumuloTableHandler.java
GCHQDev404 added a commit that referenced this issue Oct 24, 2022
@GCHQDev404
Merge branch 'gh-2630-example-real-federatedstore' into gh-2632-Feder…
7a78406 
…atedStore-RemoveGraphAndDeleteAccumuloTable
GCHQDev404 added a commit that referenced this issue Oct 25, 2022
@GCHQDev404
Merge branch 'gh-2357-federatedstore-federated-operation-merge-v2-alp…
2225c59 
…ha' into gh-2632-FederatedStore-RemoveGraphAndDeleteAccumuloTable
GCHQDev404 added a commit that referenced this issue Oct 25, 2022
@GCHQDev404
Merge remote-tracking branch 'origin/v2-alpha' into gh-2632-Federated…
89227bd 
…Store-RemoveGraphAndDeleteAccumuloTable

# Conflicts:
#	example/federated-demo/src/main/resources/federatedStore.properties
#	example/federated-demo/src/main/resources/operationDeclarations.json
#	example/real-federated-store/README.md
#	example/real-federated-store/have-a-go-at-operations/README.md
#	example/real-federated-store/have-a-go-at-operations/curl-operation-examples/curl_getAllElements.sh
#	example/real-federated-store/have-a-go-at-operations/curl-operation-examples/curl_getAllGraphIds.sh
#	example/real-federated-store/have-a-go-at-operations/curl-operation-examples/curl_getSchema.sh
#	example/real-federated-store/have-a-go-at-operations/curl-operation-examples/curl_getSchema_alternative.sh
GCHQDev404 added a commit that referenced this issue Oct 25, 2022
@GCHQDev404
gh-2632 PR request
fef4393
GCHQDev404 added a commit that referenced this issue Oct 26, 2022
@GCHQDev404
gh-2632 Add Option to Remove Graph to Handler.
3351d8a
@GCHQDev404 GCHQDev404 mentioned this issue Oct 26, 2022
Closed
@lb324567 lb324567 added p:normal enhancement Improvement to existing functionality/feature and removed p:low labels Oct 26, 2022
GCHQDev404 added a commit that referenced this issue Oct 28, 2022
@GCHQDev404
gh-2632 Ported changes to Accumulo Handler for accumulo logic.
d771f56
GCHQDev404 added a commit that referenced this issue Oct 28, 2022
@GCHQDev404
Merge remote-tracking branch 'origin/v2-alpha' into gh-2632-Federated…
4528fc7 
…Store-RemoveGraphAndDeleteAccumuloTable
GCHQDev404 added a commit that referenced this issue Oct 28, 2022
@GCHQDev404
gh-2632 tidy up
fcca881
@github-actions github-actions bot mentioned this issue Oct 28, 2022
Merged
GCHQDev404 added a commit that referenced this issue Oct 28, 2022
@GCHQDev404
gh-2632 options tests.
e25891b
GCHQDev404 added a commit that referenced this issue Oct 28, 2022
@GCHQDev404
gh-2632 options tests.
4a8c4dd
GCHQDev404 added a commit that referenced this issue Oct 28, 2022
@GCHQDev404
gh-2632 options tests.
95ec142
GCHQDev404 added a commit that referenced this issue Oct 31, 2022
@GCHQDev404
gh-2632 PR requests.
05ce0a0
GCHQDev404 added a commit that referenced this issue Oct 31, 2022
@GCHQDev404
gh-2632 PR requests. Renaming of Operation and Handlers with comments…
09def4a 
… to be more clear.
GCHQDev404 added a commit that referenced this issue Nov 2, 2022
@GCHQDev404
Merge branch 'gh-2457-double-caching-issue' into gh-2632-FederatedSto…
8d94ca9 
…re-RemoveGraphAndDeleteAccumuloTable

# Conflicts:
#	store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/FederatedGraphStorage.java
GCHQDev404 added a commit that referenced this issue Nov 2, 2022
@GCHQDev404
Merge remote-tracking branch 'origin/v2-alpha' into gh-2632-Federated…
be29cbc 
…Store-RemoveGraphAndDeleteAccumuloTable

# Conflicts:
#	store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/FederatedGraphStorage.java
GCHQDev404 added a commit that referenced this issue Nov 2, 2022
@GCHQDev404
gh-2632 PR changes
81d8517
@GCHQDev404 GCHQDev404 mentioned this issue Nov 2, 2022
Open
GCHQDev404 added a commit that referenced this issue Nov 2, 2022
@GCHQDev404
gh-2632 PR changes
ac210ae
GCHQDev404 added a commit that referenced this issue Nov 3, 2022
@GCHQDev404
Gh 2632 federated store remove graph and delete accumulo table (#2799)
2f9a5da 
* gh-2632 FederatedStore Remove Graph and Delete Accumulo table.

* gh-2632 FederatedStore Remove Graph and Delete Accumulo table. Error improvement.

* gh-2632 FederatedStore added FederatedRemoveGraphAndDeleteAccumuloTableHandler

* gh-2632 PR request

* gh-2632 Add Option to Remove Graph to Handler.

* gh-2632 Ported changes to Accumulo Handler for accumulo logic.

* gh-2632 tidy up

* gh-2632 options tests.

* gh-2632 PR requests.

* gh-2632 PR requests. Renaming of Operation and Handlers with comments to be more clear.

* gh-2632 PR changes

* gh-2632 PR changes
GCHQDev404 added a commit that referenced this issue Nov 3, 2022
@GCHQDev404
Merge branch 'gh-2632-FederatedStore-RemoveGraphAndDeleteAccumuloTabl…
91a3817 
…e' into gh-2761-federatedstore-federated-operation-merge-mapping
@t92549 t92549 linked a pull request Nov 3, 2022 that will close this issue
Gh 2632 federated store remove graph and delete accumulo table #2799
Merged
@t92549
Copy link
Contributor

t92549 commented Nov 3, 2022

Closed by #2799

@t92549 t92549 closed this as completed Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GCHQDev404 GCHQDev404

Labels
enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module
Projects
None yet
Milestone
v2.0.0-alpha-0.4
Development

Successfully merging a pull request may close this issue.

Gh 2632 federated store remove graph and delete accumulo table gchq/Gaffer
4 participants
@GCHQDev404 @n3101 @t92549 @lb324567