gh-2632 federated store remove graph and delete accumulo table #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TION_OPTIONS_GRAPH_IDS.
…aining MIDPUT generic
…federatedstore-federated-operation-remove-midput # Conflicts: # store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/operation/FederatedOperation.java
… to IFederation
…ingAdminUsage changes.
…ingAdminUsage rename.
Codecov Report
@@ Coverage Diff @@
## v2-alpha #2785 +/- ##
===========================================
Coverage ? 65.48%
Complexity ? 2187
===========================================
Files ? 546
Lines ? 17331
Branches ? 2114
===========================================
Hits ? 11350
Misses ? 5018
Partials ? 963 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
blocked waiting on #2769 |
GCHQDev404
changed the title
…ha' into gh-2630-example-real-federatedstore # Conflicts: # core/access/pom.xml # core/cache/pom.xml # core/common-util/pom.xml # core/data/pom.xml # core/exception/pom.xml # core/graph/pom.xml # core/operation/README.md # core/operation/pom.xml # core/pom.xml # core/serialisation/pom.xml # core/store/pom.xml # core/store/src/main/java/uk/gov/gchq/gaffer/store/Store.java # core/store/src/main/java/uk/gov/gchq/gaffer/store/operation/handler/HasTraitHandler.java # core/store/src/test/java/uk/gov/gchq/gaffer/store/StoreTest.java # core/store/src/test/java/uk/gov/gchq/gaffer/store/operation/handler/HasTraitHandlerTest.java # core/type/pom.xml # example/basic/basic-model/pom.xml # example/basic/basic-rest/pom.xml # example/basic/pom.xml # example/federated-demo/pom.xml # example/pom.xml # example/road-traffic/pom.xml # example/road-traffic/road-traffic-demo/pom.xml # example/road-traffic/road-traffic-generators/pom.xml # example/road-traffic/road-traffic-model/pom.xml # example/road-traffic/road-traffic-rest/pom.xml # integration-test/pom.xml # library/bitmap-library/pom.xml # library/cache-library/hazelcast-cache-service/pom.xml # library/cache-library/hazelcast-cache-service/src/test/resources/hazelcast.xml # library/cache-library/jcs-cache-service/pom.xml # library/cache-library/pom.xml # library/flink-library/pom.xml # library/hdfs-library/pom.xml # library/pom.xml # library/sketches-library/pom.xml # library/spark/pom.xml # library/spark/spark-accumulo-library/pom.xml # library/spark/spark-library/pom.xml # library/time-library/pom.xml # pom.xml # rest-api/accumulo-rest/pom.xml # rest-api/common-rest/pom.xml # rest-api/common-rest/src/main/java/uk/gov/gchq/gaffer/rest/SystemProperty.java # rest-api/common-rest/src/main/resources/version.properties # rest-api/core-rest/pom.xml # rest-api/hbase-rest/pom.xml # rest-api/map-rest/pom.xml # rest-api/parquet-rest/pom.xml # rest-api/pom.xml # rest-api/spring-rest/pom.xml # store-implementation/accumulo-store/pom.xml # store-implementation/accumulo-store/src/main/java/uk/gov/gchq/gaffer/accumulostore/retriever/AccumuloSetRetriever.java # store-implementation/accumulo-store/src/test/java/uk/gov/gchq/gaffer/accumulostore/operation/handler/GetElementsWithinSetHandlerTest.java # store-implementation/accumulo-store/src/test/java/uk/gov/gchq/gaffer/accumulostore/retriever/impl/AccumuloIDWithinSetRetrieverTest.java # store-implementation/federated-store/pom.xml # store-implementation/federated-store/src/test/java/uk/gov/gchq/gaffer/federatedstore/FederatedGraphStorageTraitsTest.java # store-implementation/federated-store/src/test/java/uk/gov/gchq/gaffer/federatedstore/FederatedStoreGetTraitsTest.java # store-implementation/hbase-store/README.md # store-implementation/hbase-store/pom.xml # store-implementation/hbase-store/src/main/java/uk/gov/gchq/gaffer/hbasestore/HBaseStore.java # store-implementation/map-store/pom.xml # store-implementation/parquet-store/README.md # store-implementation/parquet-store/pom.xml # store-implementation/parquet-store/src/main/java/uk/gov/gchq/gaffer/parquetstore/ParquetStore.java # store-implementation/pom.xml # store-implementation/proxy-store/pom.xml
…atedstore-delete-accumulo-table # Conflicts: # example/federated-demo/src/main/resources/operationDeclarations.json # store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/FederatedGraphStorage.java # store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/util/FederatedStoreUtil.java
…e' into gh-2632-federatedstore-delete-accumulo-table # Conflicts: # store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/operation/handler/impl/FederatedRemoveGraphDeleteAccumuloTableHandler.java
GCHQDev404
force-pushed
the
gh-2632-FederatedStore-RemoveGraphAndDeleteAccumuloTable
branch
from
617f2f7
to
8e1fc24
Compare
|
blocked waiting on #2631 |
…eal-federatedstore # Conflicts: # store-implementation/federated-store/src/test/java/uk/gov/gchq/gaffer/federatedstore/FederatedStoreCacheBackwardCompatibilityTest.java # store-implementation/federated-store/src/test/java/uk/gov/gchq/gaffer/federatedstore/FederatedStoreTest.java
GCHQDev404
deleted the
gh-2632-FederatedStore-RemoveGraphAndDeleteAccumuloTable
branch
GCHQDev404
restored the
gh-2632-FederatedStore-RemoveGraphAndDeleteAccumuloTable
branch
…atedStore-RemoveGraphAndDeleteAccumuloTable
…store-hotfix # Conflicts: # store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/operation/handler/impl/FederatedOperationHandler.java # store-implementation/federated-store/src/test/java/uk/gov/gchq/gaffer/federatedstore/FederatedStoreCacheBackwardCompatibilityTest.java # store-implementation/federated-store/src/test/java/uk/gov/gchq/gaffer/federatedstore/operation/handler/FederatedOperationHandlerTest.java
…ha' into gh-2632-FederatedStore-RemoveGraphAndDeleteAccumuloTable
t92549
reviewed
Oct 25, 2022
| * @see FederatedStore | ||
| * @see RemoveGraph | ||
| */ | ||
| public class FederatedRemoveGraphDeleteAccumuloTableHandler extends FederatedRemoveGraphHandler { |
There was a problem hiding this comment.
Could this be done as a DeleteGraph operation that is implemented by MapStore and AccumuloStore, and the FederatedStore can pass that to the relevant store? As part of remove graph?
There was a problem hiding this comment.
A Mapstore just stops existing.
AccumuloStore possibly it deletes the table, but the Accumlo instance continues to live.
This is possibly useful.
Federation would need to send DeleteGraph operation to all stores. Only AccumuloStore would support the operation.
Federation would still require a second Handler. I think.
*additional comment taken offline
…Store-RemoveGraphAndDeleteAccumuloTable # Conflicts: # example/federated-demo/src/main/resources/federatedStore.properties # example/federated-demo/src/main/resources/operationDeclarations.json # example/real-federated-store/README.md # example/real-federated-store/have-a-go-at-operations/README.md # example/real-federated-store/have-a-go-at-operations/curl-operation-examples/curl_getAllElements.sh # example/real-federated-store/have-a-go-at-operations/curl-operation-examples/curl_getAllGraphIds.sh # example/real-federated-store/have-a-go-at-operations/curl-operation-examples/curl_getSchema.sh # example/real-federated-store/have-a-go-at-operations/curl-operation-examples/curl_getSchema_alternative.sh
GCHQDev404
force-pushed
the
gh-2632-FederatedStore-RemoveGraphAndDeleteAccumuloTable
branch
from
9c4d5b8
to
fef4393
Compare
|
Approach requires a re-work see ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handler will require MANUAL testing against an Accumulo instance.
Remember to add the Handler to the FederatedStore config.
Related Issue