Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToCsv with OpenCypher format #2675

Closed
p3430233 opened this issue Jun 14, 2022 · 3 comments · Fixed by #2704
Closed

ToCsv with OpenCypher format #2675

p3430233 opened this issue Jun 14, 2022 · 3 comments · Fixed by #2704
Assignees
@p3430233
Labels
enhancement Improvement to existing functionality/feature
Milestone
v2.0.0-alpha-0.3.1

Comments

@p3430233
Copy link
Contributor

Be able to export elements from a graph into an openCypher formatted CSV file
@p3430233 p3430233 self-assigned this Jun 14, 2022
@t92549
Copy link
Contributor

t92549 commented Jun 14, 2022

Similar to #2558

p3430233 added a commit that referenced this issue Jul 4, 2022
@p3430233
gh-2675 adds ability to export to openCypher formatted csv
846fd04
p3430233 added a commit that referenced this issue Jul 4, 2022
@p3430233
gh-2675 added ability to export to openCypher formatted csv
61b9878
p3430233 added a commit that referenced this issue Jul 5, 2022
@p3430233
gh-2675 used static imports to access fields defined in OpenCypherCsv…
eee6e95 
…ElementGenerator
p3430233 added a commit that referenced this issue Jul 5, 2022
@p3430233
gh-2675 reorder imports
c39647f
p3430233 added a commit that referenced this issue Jul 11, 2022
@p3430233
gh-2675 removed types from everything but the property headers
928995e
p3430233 added a commit that referenced this issue Jul 13, 2022
@p3430233
gh-2675 split the ToCsv into individual operations depending on forma…
dae485d 
…t required, addded correspodning handler and test
p3430233 added a commit that referenced this issue Jul 13, 2022
@p3430233
gh-2675 ToCsv hadn't been included in last push
70a241f
p3430233 added a commit that referenced this issue Jul 19, 2022
@p3430233
gh-2675 added ToOpenCypherCsvTest, stopped ToOpenCypherCsv op extendi…
8618a10 
…ng ToCsv
p3430233 added a commit that referenced this issue Jul 19, 2022
@p3430233
gh-2675 copyrights fixed
f909583
p3430233 added a commit that referenced this issue Jul 19, 2022
@p3430233
gh-2675 added tests for the generator
57be53e
@t92549 t92549 linked a pull request Jul 20, 2022 that will close this issue
Gh-2675: Add ToOpenCypherCsv Operation #2704
Merged
@t92549 t92549 added the enhancement Improvement to existing functionality/feature label Jul 20, 2022
@t92549 t92549 added this to the v2.0.0 milestone Jul 20, 2022
p3430233 added a commit that referenced this issue Jul 21, 2022
@p3430233
gh-2675 changed tests to use assertj resolved comments from review
257db7b
p3430233 added a commit that referenced this issue Jul 22, 2022
@p3430233
gh-2675 added options and its setter and getter back in, reversed nul…
2df8187 
…l check
@p3430233 p3430233 mentioned this issue Aug 2, 2022
Closed
p3430233 added a commit that referenced this issue Aug 3, 2022
@p3430233
gh-2675 code refactor, cleaned tests
371a6d6
@t92549 t92549 changed the title ExportCsv ToCsv with OpenCypher format Aug 3, 2022
@t92549
Copy link
Contributor

t92549 commented Aug 3, 2022

The ToCsv Operation should be extended to create a Csv in the OpenCypher format. This Operation takes an Iterable of Elements and returns an Iterable of Strings representing a Csv.

@t92549 t92549 mentioned this issue Aug 3, 2022
Closed
@t92549 t92549 added the csv label Aug 3, 2022
This was referenced Aug 3, 2022
Closed
Closed
p3430233 added a commit that referenced this issue Aug 3, 2022
@p3430233
gh-2675 cleaned tests
0c95874
t92549 pushed a commit that referenced this issue Aug 4, 2022
@p3430233
Gh-2675: Add ToOpenCypherCsv Operation (#2704)
549a612 
* gh-2675 adds ability to export to openCypher formatted csv

* gh-2675 added ability to export to openCypher formatted csv

* gh-2675 used static imports to access fields defined in OpenCypherCsvElementGenerator

* gh-2675 reorder imports

* gh-2675 removed types from everything but the property headers

* gh-2675 split the ToCsv into individual operations depending on format required, addded correspodning handler and test

* gh-2675 ToCsv hadn't been included in last push

* gh-2675 added ToOpenCypherCsvTest, stopped ToOpenCypherCsv op extending ToCsv

* gh-2675 copyrights fixed

* gh-2675 added tests for the generator

* gh-2675 changed tests to use assertj resolved comments from review

* gh-2675 added options and its setter and getter back in, reversed null check

* gh-2675 code refactor, cleaned tests

* gh-2675 cleaned tests
@t92549
Copy link
Contributor

t92549 commented Aug 4, 2022

Closed by #2704

@t92549 t92549 closed this as completed Aug 4, 2022
p3430233 added a commit that referenced this issue Aug 9, 2022
@p3430233
Merge branch 'gh-2675-ExportCsv' into gh-2707-ToFile
5624437
p3430233 added a commit that referenced this issue Aug 9, 2022
@p3430233
Merge branch 'gh-2675-ExportCsv' into gh-2707-ToFile
09641d9
p3430233 added a commit that referenced this issue Aug 9, 2022
@p3430233
Merge branch 'gh-2675-ExportCsv' into gh-2707-ToFile
7f09509
@t92549 t92549 modified the milestones: v2.0.0, v2.0.0-alpha-0.3.1 Aug 10, 2022
p3430233 added a commit that referenced this issue Aug 31, 2022
@p3430233
Gh 2707 export to local file (#2729)
c137991 
* gh-2675 adds ability to export to openCypher formatted csv

* gh-2675 added ability to export to openCypher formatted csv

* gh-2675 used static imports to access fields defined in OpenCypherCsvElementGenerator

* gh-2675 reorder imports

* gh-2675 removed types from everything but the property headers

* gh-2675 split the ToCsv into individual operations depending on format required, addded correspodning handler and test

* gh-2675 ToCsv hadn't been included in last push

* gh-2707 added ToFile operation, handler and test

* gh-2707 added ToFileTest

* gh-2675 added ToOpenCypherCsvTest, stopped ToOpenCypherCsv op extending ToCsv

* gh-2675 copyrights fixed

* gh-2675 added tests for the generator

* gh-2675 changed tests to use assertj resolved comments from review

* gh-2675 added options and its setter and getter back in, reversed null check

* gh-2707 added operation, handler, and exporter for outputting iterable strings to localfile

* gh-2707 added tests and checkstyle

* gh-2707 merge conflicts resolved

* gh-2707 copyright dates

* gh-2707 txt->csv

* gh-2707 txt->csv

* gh-2707 acted on comments

* gh-2707 checkstyle
t92549 pushed a commit that referenced this issue Oct 13, 2022
@p3430233 @GCHQDev404
Gh 2723 refactor to open cypher csv (#2751)
2bb2ee9 
* gh-2675 adds ability to export to openCypher formatted csv

* gh-2675 added ability to export to openCypher formatted csv

* gh-2675 used static imports to access fields defined in OpenCypherCsvElementGenerator

* gh-2675 reorder imports

* gh-2675 removed types from everything but the property headers

* gh-2675 split the ToCsv into individual operations depending on format required, addded correspodning handler and test

* gh-2675 ToCsv hadn't been included in last push

* gh-2707 added ToFile operation, handler and test

* gh-2707 added ToFileTest

* gh-2675 added ToOpenCypherCsvTest, stopped ToOpenCypherCsv op extending ToCsv

* gh-2675 copyrights fixed

* gh-2675 added tests for the generator

* gh-2675 changed tests to use assertj resolved comments from review

* gh-2675 added options and its setter and getter back in, reversed null check

* gh-2707 added operation, handler, and exporter for outputting iterable strings to localfile

* gh-2707 added tests and checkstyle

* gh-2707 merge conflicts resolved

* gh-2707 copyright dates

* gh-2707 txt->csv

* gh-2707 txt->csv

* gh-2723 Refactored csv exports

* gh-2723 fixed test

* gh-2723 fix copyright headers

* gh-2723 gaffer identifier map initalised statically, removed getter and setters

* gh-2723 added ExportToLocalFile to list of operations

* gh-2723 CsvFormat rework

* gh-2723 refactor

* gh-2723 failing tests re-run

* gh-2723 bughunt

* gh-2723 fixed failing test

* gh-2723 checkstyle

* gh-2723 copyright headers

* gh-2723 refactor

* gh-2723 moved statics

* merge v2-alpha

* gh-2723 copyright header

* gh-2723 added tests

* Update OperationServiceV2IT.java

Co-authored-by: GCHQDev404 <GCHQDev404@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p3430233 p3430233

Labels
enhancement Improvement to existing functionality/feature
Projects
None yet
Milestone
v2.0.0-alpha-0.3.1
Development

Successfully merging a pull request may close this issue.

Gh-2675: Add ToOpenCypherCsv Operation gchq/Gaffer
2 participants
@p3430233 @t92549