Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh-2675: Add ToOpenCypherCsv Operation #2704

Merged
merged 14 commits into from Aug 4, 2022
Merged

Gh-2675: Add ToOpenCypherCsv Operation #2704

merged 14 commits into from Aug 4, 2022

Conversation

p3430233
Copy link
Contributor

@p3430233 p3430233 commented Jul 4, 2022

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 4, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@GCHQDeveloper314 GCHQDeveloper314 changed the base branch from develop to v2-alpha July 5, 2022 07:45
@GCHQDeveloper314 GCHQDeveloper314 changed the title Gh 2675 export csv Gh-2675: Export CSV Jul 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (v2-alpha@01bcbc7). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             v2-alpha    #2704   +/-   ##
===========================================
  Coverage            ?   67.24%           
  Complexity          ?     2277           
===========================================
  Files               ?      678           
  Lines               ?    21089           
  Branches            ?     2467           
===========================================
  Hits                ?    14181           
  Misses              ?     5778           
  Partials            ?     1130

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GCHQDeveloper314
Copy link
Member

As this is a work in progress, it might be better to set this as a draft PR.

There are no tests for the changes to the data and operation modules.

@p3430233 p3430233 marked this pull request as draft July 19, 2022 10:16
@p3430233 p3430233 marked this pull request as ready for review July 19, 2022 10:28
@p3430233 p3430233 marked this pull request as draft July 19, 2022 10:29
@p3430233 p3430233 marked this pull request as ready for review July 19, 2022 14:50
@t92549 t92549 linked an issue Jul 20, 2022 that may be closed by this pull request
ToCsv with OpenCypher format #2675
Closed
@t92549
Copy link
Contributor

t92549 commented Jul 20, 2022

It should be noted that this PR just provides a way to export a list of elements into lines of a csv. Another Operation will need to be added to save this to a file.

GCHQDeveloper314
GCHQDeveloper314 requested changes Jul 20, 2022
View reviewed changes
Copy link
Member

@GCHQDeveloper314 GCHQDeveloper314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some broken asserts which do nothing need to be fixed.

core/data/src/test/java/uk/gov/gchq/gaffer/data/generator/OpenCypherCsvGeneratorTest.java Outdated Show resolved Hide resolved
core/data/src/test/java/uk/gov/gchq/gaffer/data/generator/OpenCypherCsvGeneratorTest.java Outdated Show resolved Hide resolved
core/data/src/test/java/uk/gov/gchq/gaffer/data/generator/OpenCypherCsvGeneratorTest.java Outdated Show resolved Hide resolved
core/data/src/test/java/uk/gov/gchq/gaffer/data/generator/OpenCypherCsvGeneratorTest.java Outdated Show resolved Hide resolved
core/data/src/test/java/uk/gov/gchq/gaffer/data/generator/OpenCypherCsvGeneratorTest.java Outdated Show resolved Hide resolved
core/operation/src/test/java/uk/gov/gchq/gaffer/operation/impl/output/ToOpenCypherCsvTest.java Outdated Show resolved Hide resolved
core/operation/src/test/java/uk/gov/gchq/gaffer/operation/impl/output/ToOpenCypherCsvTest.java Show resolved Hide resolved
.../test/java/uk/gov/gchq/gaffer/store/operation/handler/output/ToOpenCypherCsvHandlerTest.java Outdated Show resolved Hide resolved
@p3430233 p3430233 marked this pull request as draft August 2, 2022 10:18
@t92549 t92549 changed the title Gh-2675: Export CSV Gh-2675: Add ToOpenCypherCsv Operation Aug 3, 2022
@t92549 t92549 marked this pull request as ready for review August 3, 2022 11:25
@t92549 t92549 mentioned this pull request Aug 3, 2022
Closed
t92549
t92549 reviewed Aug 3, 2022
View reviewed changes
.../test/java/uk/gov/gchq/gaffer/store/operation/handler/output/ToOpenCypherCsvHandlerTest.java
//Then
final List<String> resultList = Lists.newArrayList(results);
final List<String> expected = Arrays.asList(
":ID,:LABEL,:TYPE,:START_ID,:END_ID,count:Integer,DIRECTED:Boolean",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this says Integer rather than Int, but it will be fixed by #2726

@t92549 t92549 merged commit 549a612 into v2-alpha Aug 4, 2022
@t92549 t92549 deleted the gh-2675-ExportCsv branch August 4, 2022 14:42
@t92549 t92549 mentioned this pull request Aug 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t92549 t92549 t92549 approved these changes

@lb324567 lb324567 lb324567 left review comments

@GCHQDeveloper314 GCHQDeveloper314 GCHQDeveloper314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ToCsv with OpenCypher format
6 participants
@p3430233 @CLAassistant @codecov-commenter @GCHQDeveloper314 @t92549 @lb324567