Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hllp is not aggregated properly with TSV #2749

Closed
t92549 opened this issue Sep 8, 2022 · 1 comment · Fixed by #2800
Closed

Hllp is not aggregated properly with TSV #2749

t92549 opened this issue Sep 8, 2022 · 1 comment · Fixed by #2800
Assignees
@r32575
Labels
bug Confirmed or suspected bug
Milestone
v2.0.0-alpha-0.4

Comments

@t92549
Copy link
Contributor

t92549 commented Sep 8, 2022

When TypeSubtypeValue vertices are used, Gaffer does not correctly aggregate HLLP properties that are provided over json:

Gaffer/library/sketches-library/src/main/java/uk/gov/gchq/gaffer/sketches/clearspring/cardinality/serialisation/json/HyperLogLogPlusJsonDeserialiser.java

Line 64 in 580cf2b

final ArrayNode offers = (ArrayNode) treeNode.get("offers");

@t92549 t92549 added the bug Confirmed or suspected bug label Sep 8, 2022
@t92549 t92549 added this to the v2.0.0-alpha-0.4 milestone Sep 8, 2022
@r32575 r32575 added the needs-elaboration Requires further detail and explanation label Sep 13, 2022
@r32575 r32575 self-assigned this Sep 26, 2022
@github-actions github-actions bot mentioned this issue Oct 31, 2022
Merged
@GCHQDeveloper314 GCHQDeveloper314 linked a pull request Nov 1, 2022 that will close this issue
Gh-2749: Hllp is not aggregated properly with TSV #2800
Merged
@t92549 t92549 mentioned this issue Nov 15, 2022
Closed
r32575 added a commit that referenced this issue Nov 15, 2022
@r32575
Gh-2749: Hllp is not aggregated properly with TSV (#2800)
cb9a1c9 
* Fixed the bug when deserialising. The objects passed in are now instantiated before being offered to HyperLogLogPlus

* Fixed checkstyle

* Ran spotless

* Found a less hacky method of deserialising JSON. Unfortunately, nested offers objects are not supported
@t92549
Copy link
Contributor Author

t92549 commented Nov 15, 2022

Fixed by #2800

@t92549 t92549 closed this as completed Nov 15, 2022
@t92549 t92549 removed the needs-elaboration Requires further detail and explanation label Nov 15, 2022
@t92549 t92549 mentioned this issue Nov 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r32575 r32575

Labels
bug Confirmed or suspected bug
Projects
None yet
Milestone
v2.0.0-alpha-0.4
Development

Successfully merging a pull request may close this issue.

Gh-2749: Hllp is not aggregated properly with TSV gchq/Gaffer
2 participants
@r32575 @t92549