Gh-2749: Hllp is not aggregated properly with TSV #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntiated before being offered to HyperLogLogPlus
Codecov Report
@@ Coverage Diff @@
## v2-alpha #2800 +/- ##
===========================================
Coverage ? 56.47%
Complexity ? 2495
===========================================
Files ? 917
Lines ? 32316
Branches ? 3319
===========================================
Hits ? 18251
Misses ? 12673
Partials ? 1392 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
GCHQDeveloper314
changed the title
GCHQDeveloper314
changed the title
t92549
reviewed
Nov 3, 2022
...fer/sketches/clearspring/cardinality/serialisation/json/HyperLogLogPlusJsonDeserialiser.java
Outdated
Show resolved
Hide resolved
...sketches/clearspring/cardinality/serialisation/json/HyperLogLogPlusJsonDeserialiserTest.java
Outdated
Show resolved
Hide resolved
...ketches/clearspring/cardinality/serialisation/json/HyperLogLogPlusJsonSerialisationTest.java
Outdated
Show resolved
Hide resolved
core/type/src/main/java/uk/gov/gchq/gaffer/types/TypeSubTypeValue.java
Outdated
Show resolved
Hide resolved
…d offers objects are not supported
t92549
approved these changes
Nov 11, 2022
lb324567
approved these changes
Nov 14, 2022
...sketches/clearspring/cardinality/serialisation/json/HyperLogLogPlusJsonDeserialiserTest.java
Outdated
Show resolved
Hide resolved
GCHQDeveloper314
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HyperLogLogPluswas attempting to add the text version of theJsonNodewhich returned an empty string for an object. Have now reworked so theJsonNodeis now examined and if aclassfield is found attempts to instantiate the object and send this to theHyperLogLogPlus.Related Issue