Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Gaffer TinkerPop code to core Gaffer #2983

Closed
t92549 opened this issue Jun 21, 2023 · 0 comments · Fixed by #2984
Closed

Move Gaffer TinkerPop code to core Gaffer #2983

t92549 opened this issue Jun 21, 2023 · 0 comments · Fixed by #2984
Assignees
@t92549
Labels
headliner Used to tag major items for release notes tinkerpop Specific to/touches the tinkerpop module
Milestone
v2.1.0

Comments

@t92549
Copy link
Contributor

t92549 commented Jun 21, 2023 •
edited

Gaffer used to contain a TinkerPop implementation so that users could query Gaffer graphs with the Gremlin query language. This was moved to the now archived gaffer-experimental repository. It should be moved back into core Gaffer so Gaffer graphs can be queried with gremlin.

This effectively reverses #460. The code should also be brought up to date with modern Gaffer and TinkerPop.
@t92549 t92549 added the headliner Used to tag major items for release notes label Jun 21, 2023
@t92549 t92549 added this to the v2.1.0 milestone Jun 21, 2023
@t92549 t92549 self-assigned this Jun 21, 2023
@github-actions github-actions bot mentioned this issue Jun 22, 2023
Merged
@t92549 t92549 added the tinkerpop Specific to/touches the tinkerpop module label Jun 22, 2023
GCHQDeveloper314 pushed a commit that referenced this issue Jun 27, 2023
@t92549
Gh-2983: Re-add Gaffer tinkerpop code (#2984)
920bbc3 
* Re-add Gaffer tinkerpop code

* Add new module to CI

* Fix JsonIgnore test failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t92549 t92549

Labels
headliner Used to tag major items for release notes tinkerpop Specific to/touches the tinkerpop module
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

Gh-2983: Re-add Gaffer tinkerpop code gchq/Gaffer
1 participant
@t92549