Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-2983: Re-add Gaffer tinkerpop code #2984

Merged
merged 15 commits into from
Jun 27, 2023

Conversation

t92549
Copy link
Contributor

@t92549 t92549 commented Jun 22, 2023

tinkerpop/pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@GCHQDeveloper314 GCHQDeveloper314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. Various classes don't have any Javadoc, although some of these might inherit which may be ok.

tinkerpop/src/test/resources/log4j.xml Outdated Show resolved Hide resolved
tinkerpop/pom.xml Outdated Show resolved Hide resolved
tinkerpop/pom.xml Outdated Show resolved Hide resolved
tinkerpop/pom.xml Outdated Show resolved Hide resolved
tinkerpop/pom.xml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #2984 (9cc8023) into develop (6dda8c8) will decrease coverage by 0.20%.
The diff coverage is 57.16%.

@@              Coverage Diff              @@
##             develop    #2984      +/-   ##
=============================================
- Coverage      65.35%   65.15%   -0.20%     
- Complexity      2510     2634     +124     
=============================================
  Files            885      901      +16     
  Lines          28197    28797     +600     
  Branches        3164     3238      +74     
=============================================
+ Hits           18429    18764     +335     
- Misses          8368     8576     +208     
- Partials        1400     1457      +57     
Impacted Files Coverage Δ
...tinkerpop/generator/GafferPopElementGenerator.java 0.00% <0.00%> (ø)
...inkerpop/gremlinplugin/GafferPopGremlinPlugin.java 0.00% <0.00%> (ø)
...kerpop/service/GafferPopNamedOperationService.java 0.00% <0.00%> (ø)
...re/operation/impl/GetElementsBetweenSetsPairs.java 90.00% <ø> (-4.00%) ⬇️
...gchq/gaffer/tinkerpop/GafferPopVertexProperty.java 32.35% <32.35%> (ø)
.../gchq/gaffer/tinkerpop/GafferPopGraphFeatures.java 43.47% <43.47%> (ø)
...service/GafferPopNamedOperationServiceFactory.java 50.00% <50.00%> (ø)
...gchq/gaffer/tinkerpop/GafferPopGraphVariables.java 55.55% <55.55%> (ø)
...fer/tinkerpop/generator/GafferEntityGenerator.java 60.00% <60.00%> (ø)
...k/gov/gchq/gaffer/tinkerpop/GafferPopProperty.java 61.53% <61.53%> (ø)
... and 7 more

... and 1 file with indirect coverage changes

@GCHQDeveloper314 GCHQDeveloper314 merged commit 920bbc3 into develop Jun 27, 2023
@GCHQDeveloper314 GCHQDeveloper314 deleted the gh-2983-gaffer-tinkerpop branch June 27, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Gaffer TinkerPop code to core Gaffer
2 participants