Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TInkerpop Predicates can't be serialised #3229

Closed
tb06904 opened this issue Jun 5, 2024 · 0 comments · Fixed by #3231
Closed

TInkerpop Predicates can't be serialised #3229

tb06904 opened this issue Jun 5, 2024 · 0 comments · Fixed by #3231
Assignees
@p29876
Labels
bug Confirmed or suspected bug tinkerpop Specific to/touches the tinkerpop module
Milestone
v2.2.2

Comments

@tb06904
Copy link
Member

tb06904 commented Jun 5, 2024

Describe the bug
We currently use the Tinkerpop P class and extract the predicates to be used from it directly but this class cannot be deserialised so fails if using an accumulo store. We should probably just translate these to Koryphe ones instead.
@tb06904 tb06904 added bug Confirmed or suspected bug tinkerpop Specific to/touches the tinkerpop module labels Jun 5, 2024
p29876 added a commit that referenced this issue Jun 5, 2024
@p29876
Gh-3229 Translate Tinkerpop predicates to Koryphe predicates
6f607c6 
fixes serialisation issues with accumulo
change HasStepIT tests to use accumulo to catch errors
tb06904 added a commit that referenced this issue Jun 6, 2024
@tb06904
Merge remote-tracking branch 'origin/develop' into gh-3229-tinkerpop-…
7f42df4 
…predicate-serialisation-bug
@p29876 p29876 linked a pull request Jun 6, 2024 that will close this issue
Gh-3229: Tinkerpop predicate serialisation bug #3231
Merged
@github-actions github-actions bot mentioned this issue Jun 6, 2024
Merged
@GCHQDeveloper314 GCHQDeveloper314 added this to the v2.2.2 milestone Jun 7, 2024
tb06904 added a commit that referenced this issue Jun 11, 2024
@tb06904
Merge branch 'develop' into gh-3229-tinkerpop-predicate-serialisation…
7554071 
…-bug
p29876 added a commit that referenced this issue Jun 12, 2024
@p29876
Merge branch 'develop' into gh-3229-tinkerpop-predicate-serialisation…
d0f772f 
…-bug
p29876 added a commit that referenced this issue Jun 12, 2024
@p29876
Merge branch 'develop' into gh-3229-tinkerpop-predicate-serialisation…
cf4b1c8 
…-bug
l46978 pushed a commit that referenced this issue Jun 14, 2024
@p29876 @tb06904
Gh-3229: Tinkerpop predicate serialisation bug (#3231)
3473cb9 
* Gh-3229 Translate Tinkerpop predicates to Koryphe predicates

fixes serialisation issues with accumulo
change HasStepIT tests to use accumulo to catch errors

* Apply additional fixes for cypher and move to utility class for factory

* move class

* refactor Has filtering to use GlobalViewElementDefinitions

delete unused methods in GafferPopGraph
update tests

* update comment

* add tests for coverage

* checkstyle

* wrong junit import

* update errors

* sonarcloud

* lists are iterable

---------

Co-authored-by: tb06904 <141412860+tb06904@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p29876 p29876

Labels
bug Confirmed or suspected bug tinkerpop Specific to/touches the tinkerpop module
Projects
None yet
Milestone
v2.2.2
Development

Successfully merging a pull request may close this issue.

Gh-3229: Tinkerpop predicate serialisation bug gchq/Gaffer
3 participants
@GCHQDeveloper314 @tb06904 @p29876