gh-1612 - ExtractWalkVertex and test added #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1613 +/- ##
=============================================
+ Coverage 66.22% 66.22% +<.01%
Complexity 1841 1841
=============================================
Files 768 769 +1
Lines 24871 24877 +6
Branches 3228 3228
=============================================
+ Hits 16470 16476 +6
Misses 7119 7119
Partials 1282 1282
Continue to review full report at Codecov.
|
t616178
reviewed
Jan 11, 2018
| import uk.gov.gchq.gaffer.data.graph.Walk; | ||
| import uk.gov.gchq.koryphe.function.KorypheFunction; | ||
|
|
||
| public class ExtractWalkVertex extends KorypheFunction<Walk, Object> { |
There was a problem hiding this comment.
Could you add some Javadoc describing this function please?
t616178
reviewed
Jan 11, 2018
| if (null == walk) { | ||
| throw new IllegalArgumentException("Walk cannot be null"); | ||
| } | ||
| return Iterables.get(walk.getEntities().get(0), 0).getVertex(); |
There was a problem hiding this comment.
Might there be a use case where having this functionality as part of the Walk class might be useful as well? Would methods like:
walk.getStartVertex()
or
walk.getDestinationVertices()
be useful?
t616178
suggested changes
Jan 15, 2018
| @@ -188,6 +188,16 @@ public boolean isPath() { | |||
| return distinct(getVerticesOrdered()); | |||
| } | |||
|
|
|||
| @JsonIgnore | |||
| public Object getSourceVertex() { | |||
| return entities.get(0).getKey(); | |||
There was a problem hiding this comment.
Could you add some unit tests for these methods please?
t616178
approved these changes
Jan 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.