Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further simplification for extracting initial Vertex/Vertices of a GetWalks operation #1612

Closed
m607123 opened this issue Jan 8, 2018 · 1 comment
Closed

Further simplification for extracting initial Vertex/Vertices of a GetWalks operation #1612

m607123 opened this issue Jan 8, 2018 · 1 comment
Assignees
@m607123
Labels
enhancement Improvement to existing functionality/feature

Comments

@m607123
Copy link
Contributor

m607123 commented Jan 8, 2018 •
edited

After the recent update to the GetWalks operation, the results now also include the entities.
From this, a new ExtractWalkVertex operation could be written, to further reduce the number of steps required to achieve the initial goal outlined in #1345.
@m607123 m607123 self-assigned this Jan 8, 2018
@m607123 m607123 added the enhancement Improvement to existing functionality/feature label Jan 8, 2018
m607123 added a commit that referenced this issue Jan 9, 2018
@m607123
gh-1612 - ExtractWalkVertex and test added
73b045f
This was referenced Jan 9, 2018
Closed
Closed
m607123 added a commit that referenced this issue Jan 11, 2018
@m607123
gh-1612 - missing javadoc added
84a3de5
m607123 added a commit that referenced this issue Jan 11, 2018
@m607123
Merge branch 'develop' into gh-1612-extractwalkvertexfromhop
ee980a2
m607123 added a commit that referenced this issue Jan 15, 2018
@m607123
gh-1612 - Moved functionality to Walk class
0de8c76
m607123 added a commit that referenced this issue Jan 15, 2018
@m607123
Merge branch 'develop' into gh-1612-extractwalkvertexfromhop
0b7d5fd
m607123 added a commit that referenced this issue Jan 16, 2018
@m607123
gh-1612 - Tests added for new functionality
9906111
t616178 added a commit that referenced this issue Jan 17, 2018
@t616178
gh-1612 - Reordered assertEquals() parameters
d75f3e5
t616178 added a commit that referenced this issue Jan 17, 2018
@t616178
gh-1612 - Added some extra test cases
05ff7ea
t616178 added a commit that referenced this issue Jan 17, 2018
@t616178
Merge pull request #1613 from gchq/gh-1612-extractwalkvertexfromhop
bebe620 
gh-1612 - ExtractWalkVertex and test added
@t616178
Copy link
Contributor

t616178 commented Jan 17, 2018

Merged into develop

@t616178 t616178 closed this as completed Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m607123 m607123

Labels
enhancement Improvement to existing functionality/feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@t616178 @m607123