Gh-3094: Allow services to use different cache implementations #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and Properties classes to use these Excludes Federated Store changes
Includes removing redundant inheritance from FederatedStoreCache.
Mostly changes to use FederatedStoreProperties instead of general properties and remove usage of empty properties
Also allow new property in deprecated method
|
Further work is required to add testing for the new multi-cache implementation and to remove as much use of deprecated code as possible, while also adding tests to ensure external code using deprecated methods can still work to some degree. |
Also fix missing generics in Cache.java
Change log4j test settings for cache module to show DEBUG messages
…ache-implementations
The previous approach replaced the class but this wasn't required as re-initialising was already ignored. Now it warns with more details.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3147 +/- ##
=============================================
+ Coverage 66.34% 66.70% +0.36%
- Complexity 2544 2556 +12
=============================================
Files 907 907
Lines 28975 29063 +88
Branches 3216 3239 +23
=============================================
+ Hits 19223 19387 +164
+ Misses 8319 8241 -78
- Partials 1433 1435 +2 ☔ View full report in Codecov by Sentry. |
…Store Improve handling to set the missing cache property instead of behaving as if it was
cn337131
reviewed
Feb 13, 2024
cn337131
reviewed
Feb 20, 2024
core/cache/src/test/java/uk/gov/gchq/gaffer/cache/CacheTest.java
Outdated
Show resolved
Hide resolved
…ache-implementations
…ache-implementations Also remove some old JUnit assertions from FederatedGraphStorageTest.java
tb06904
reviewed
Feb 23, 2024
...n/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/FederatedGraphStorage.java
Outdated
Show resolved
Hide resolved
...n/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/FederatedGraphStorage.java
Show resolved
Hide resolved
...ated-store/src/test/java/uk/gov/gchq/gaffer/federatedstore/FederatedStorePropertiesTest.java
Outdated
Show resolved
Hide resolved
These can be used to access these caches without repeatly recreating the Cache objects elsewhere or trying to get the Service directly
…ting them and add a new test for multiple cache instances
tb06904
approved these changes
Mar 12, 2024
cn337131
approved these changes
Mar 12, 2024
GCHQDeveloper314
deleted the
gh-3094-allow-services-to-use-different-cache-implementations
branch
This was referenced Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue