Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build Sleeper CLI Docker images against develop #2857

Closed
patchwork01 opened this issue Jul 9, 2024 · 0 comments · Fixed by #2963
Closed

Only build Sleeper CLI Docker images against develop #2857

patchwork01 opened this issue Jul 9, 2024 · 0 comments · Fixed by #2963
Assignees
Milestone

Comments

@patchwork01
Copy link
Collaborator

patchwork01 commented Jul 9, 2024

Background

Split from:

Description

Since we're only able to retain a single tag for each Docker image in GHCR, we'd like to only push the develop version.

Analysis

We can change it to use the latest tag for the develop version. We can stop using any other tags than latest.

Ultimately we'd like to avoid putting any Sleeper code into these Docker images, but we can keep it as it is for the environment image for now as well.

Here are some places that reference the Docker images by their GitHub Container Registry image name:

  • The CLI install script (?)
  • The CLI script to run Docker
  • The Dev Container configuration
  • The GitHub Actions workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants