Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase code coverage for termshark to 80% #37

Open
pocc opened this issue May 16, 2019 · 1 comment
Open

Increase code coverage for termshark to 80% #37

pocc opened this issue May 16, 2019 · 1 comment
Labels
feature request New feature or request

Comments

@pocc
Copy link
Collaborator

pocc commented May 16, 2019

I might be missing something, but I'm not seeing test functions in termshark.go. It looks like there's a smattering of unit tests scattered throughout other files, which is good. More unit tests for the main file would be helpful here (and goes hand in hand with #20).

@pocc pocc added the feature request New feature or request label May 16, 2019
@pocc
Copy link
Collaborator Author

pocc commented May 16, 2019

Changing title to increasing code coverage. Currently, it looks like code coverage is 23%.

bash-5.0$ go test -coverprofile=c.out ./termshark
ok  	_/Users/rj/code/termshark	0.303s	coverage: 23.2% of statements

@pocc pocc changed the title Add tests for termshark.go Increase code coverage for termshark.go to 80% May 16, 2019
@pocc pocc changed the title Increase code coverage for termshark.go to 80% Increase code coverage for termshark to 80% May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant