Crash when set New tab URL option

[LinArcX]

Hi. in brave browser when i want to set New tab URL option to:
chrome://newtab/
And restart the brave, it try to open unlimited tabs and crash and i should manually force close it.

Os: Arch linux
Brave: Version 0.62.51 Chromium: 73.0.3683.103 (Official Build) unknown (64-bit)

[gdh1995]

Um, it indeed can not should never be chrome://newtab...

I once added some checks for this type of errors, but it seems that they failed in warning you.

You need to go to the "User Data" folder of brave browser, find a file of "Default / Extension / *** / pages / newtab.js" and delete it. Then you may get a blank new page, so you can open "chrome://extensions/" to configure Vimium C.

[LinArcX]

It's not working. after delete that file, when i open brave again, it opens again.
And after that open chrome://extensions/ page, i see this value for New tab URL setting :
chrome-search://local-ntp/local-ntp.html
Tip: If you inspect normal new tab page in brave you can see that address in inspector. i pick it up from there actually.

[gdh1995]

Please modify to "pages/blank.html" for now. I'll explain how this happen later.

Sorry, I misunderstood your last comment.

[gdh1995]

On Chrome / the original Chromium, "chrome-search://local-ntp/local-ntp.html" always means a inner page which is handled by Chrome itself, and then Vimium C use it to show a "native" new tab page - it's just like the page you see on Chrome without Vimium C installed.

But, according to what you say, the Brave browser change this logic, and the page "local-ntp.html" does some I haven't wanted.

Therefore, I need to do more tests on the brave browser by myself, but I have only Windows 10 - I wish this issue can be reproduced on Win 10.

[gdh1995]

Updated: I'm sorry but I didn't fullly understand what's your current situation. Could you explain it in detail again? Thanks for your patience.

On my PC (Windows 10 x64), I installed the stable version of brave browser (version 73), and installed Vimium C, set its "New tab URL" to "chrome-search://local-ntp/local-ntp.html".

The result looks like this:

It seems that the page worked as expected on my computer.

Have you installed some other extensions? Please list them and I'll try them.

[LinArcX]

Look at this:
https://raw.githubusercontent.com/LinArcX/Ganje/master/Images/LinArcx/Screenshot%20from%202019-04-12%2012-10-21.png
I want to set this page as "New tab URL".

[gdh1995]

Well, after some hard searching, the conclusion is that it's an impossible task for the current released version of Vimium C.

I'll publish another version of Vimium C in days, which does not override the "chrome://newtab/" page.

But there's another road of just changing Vimium C to remove the overriding. I'm still considering which one to choose.

[gdh1995]

Since my feature request on brave-browser is backlogged, I have to admit that it's still impossible for (the latest) v1.74.7 of Vimium C.

I've added an advanced option Focus web page when creating a new tab to Vimium C, and the idea of publishing another version has been given up. So, if you are still interested in Vimium C, you may compile it by yourself: https://github.com/gdh1995/vimium-c#building .