Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ommibar is Too Slow #291

Closed
jetrosut opened this issue Feb 22, 2021 · 4 comments
Closed

Ommibar is Too Slow #291

jetrosut opened this issue Feb 22, 2021 · 4 comments

Comments

@jetrosut
Copy link

jetrosut commented Feb 22, 2021

  1. Press 'o' to open the omnibar.
  2. Hit 'm' to search with the engine mapped to 'm'.

When I do this quickly, it instead opens both the omnibar and the 'Create mark..." prompt. Is there any way to reduce Omnibar's response delay? If performed a bit slower, then only the omnibar will show up, though it will not see the 'm' input unless 'm' is pressed a bit later.

@gdh1995
Copy link
Owner

gdh1995 commented Feb 22, 2021

What's your browser and test page? or does this problem occur on all normal web pages including Google search result pages?

If it does occur on all pages, then please try: 1) turning off most other browser extensions, 2) and doing same tests on https://gdh1995.cn/vimium-c/keyboard-test.html .

@jetrosut
Copy link
Author

jetrosut commented Feb 22, 2021

On Chromium 85.0 with about 20 extensions enabled. Happens probably on all pages, just tested on Github.

  Event Code Key Modifiers KeyCode (legacy)
1 keydown KeyO o   79
2 keypress KeyO o   111
3 keydown KeyM m   77
4 keypress KeyM m   109
5 keyup KeyO o   79
6 keyup KeyM m   77
7 keydown KeyO o   79
8 keypress KeyO o   111
9 keydown KeyM m   77
10 keypress KeyM m   109
11 keyup KeyO o   79
12 keyup KeyM m   77
13 keydown KeyO o   79
14 keypress KeyO o   111
15 keydown KeyM m   77
16 keypress KeyM m   109
17 keyup KeyO o   79
18 keyup KeyM m   77
19 keydown KeyO o   79
20 keypress KeyO o   111
21 keydown KeyM m   77
22 keypress KeyM m   109
23 keyup KeyO o   79
24 keyup KeyM m   77
25 keydown KeyO o   79
26 keypress KeyO o   111
27 keydown KeyM m   77
28 keypress KeyM m   109
29 keyup KeyO o   79
30 keyup KeyM m   77

I updated the original issue, by the way.

@gdh1995
Copy link
Owner

gdh1995 commented Feb 25, 2021

As a working around, you may use map o Vomnibar noSessions="start", and then Vomnibar won't show a list of recently closed tabs (neither preload all browsering history items), which means it will be a bit faster.

@gdh1995
Copy link
Owner

gdh1995 commented Feb 25, 2021

When I do this quickly, it instead opens both the omnibar and the 'Create mark..." prompt

It seems you triggered two commands during very small time. Up to now there's no efficient way to prevent it.

If performed a bit slower, then only the omnibar will show up, though it will not see the 'm' input

Vomnibar will create a hidden <iframe>, while not set it visible until all resources and a first suggestion list are determined, in order to avoid UI flickering.

Considering Vomnibar's <input> can only accept typed characters when it's visible, so Vomnibar blocks most keyboard events during the initing process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants