Skip to content

Commit

Permalink
fixing bugs: 1.wrong breakpoint set error message 2.crash on gdb exit…
Browse files Browse the repository at this point in the history
… without a stop reason
  • Loading branch information
Alexander Petukhov committed Apr 8, 2012
1 parent d6328a7 commit 21a66f2
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 17 deletions.
9 changes: 9 additions & 0 deletions debugger/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
08-04-2012 Alexander Petukhov <devel@apetukhov.ru>

* fixed a bug with wrong error message when a breakpoint condition/hitscounr can't be set
* fixed a bug when gdb exits without a stop reason

07-04-2012 Alexander Petukhov <devel@apetukhov.ru>

* fixed a bug with calltips still being shown when a pointer leaves editor window

04-04-2012 Alexander Petukhov <devel@apetukhov.ru>

* fixing exiting with code case that was unhandled and caused SIGSEGV (gdb)
Expand Down
34 changes: 19 additions & 15 deletions debugger/TODO
Original file line number Diff line number Diff line change
@@ -1,23 +1,27 @@
BUGS:

FEATURES:
- custom tooltip with sticking facilities
- don't hide a tooltip until run hasn't happent, move it if document is being scrolled
- use lexer to lookup for a symbol under cursor when presenting a tooltip
- geany menu integration
- toolbar buttons

- debug callbacks names (refactoring)
- gdb backend step speed
- windows support

- attach functionality: dbm_ methods providing target lists, common dialog
- interrupt thread using stack window
- step back

- margin context menu
- editor context menu (add watch, add/remove breakpoint)
- step back

- font from the geany settings for a message window
- use left/right keys to collapse/expand in breakpoints tree
- use lexer to lookup for a symbol under cursor when presenting a tooltip
- a button in the upper right path of a right notebook for a hiding/showing button panel
- minimum width of the debug panel notebooks
- tree views column width/autowidth
- attach functionality: dbm_ methods providing target lists, common dialog
- custom tooltip on breaks and stack trace windows with code snippet around break or frame
- custom tooltip(in an editor in debug mode) with sticking facilities
- don't hide a tooltip until run hasn't happent, move it if document is being scrolled

- android support
- bashdb support
- windows support
- gdb backend step speed
- debug callbacks names
- interrupt thread using stack window
- custom tooltip on breaks and stack trace windows with code snippet around break or frame
- font from the geany settings for a message window
- a button in the upper right path of a right notebook for a hiding/showing button panel
- use left/right keys to collapse/expand in breakpoints tree
5 changes: 3 additions & 2 deletions debugger/src/dbm_gdb.c
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@ static gboolean on_read_from_gdb(GIOChannel * src, GIOCondition cond, gpointer d
else
{
/* somehow, sometimes there can be no stop reason */
stop_reason = SR_END_STEPPING_RANGE;
stop_reason = SR_EXITED_NORMALLY;
}

if (SR_BREAKPOINT_HIT == stop_reason || SR_END_STEPPING_RANGE == stop_reason || SR_SIGNAL_RECIEVED == stop_reason)
Expand Down Expand Up @@ -817,7 +817,6 @@ gboolean run(const gchar* file, const gchar* commandline, GList* env, GList *wit
commands = add_to_queue(commands, NULL, command->str, error_message->str, TRUE);

g_string_free(command, TRUE);
g_string_free(error_message, TRUE);

if (bp->hitscount)
{
Expand All @@ -841,6 +840,8 @@ gboolean run(const gchar* file, const gchar* commandline, GList* env, GList *wit
g_string_free(command, TRUE);
}

g_string_free(error_message, TRUE);

bp_index++;
biter = biter->next;
}
Expand Down

0 comments on commit 21a66f2

Please sign in to comment.