debugger: Fix crash with GDB 7.7 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GDB 7.7 doesn't understand `&` as an argument to `-exec-run`. Moreover, the code handling errors from GDB has an issue with this error and leads to a crash. Closes https://sourceforge.net/p/geany-plugins/bugs/112/
|
I install geany 2.4.1 and geany-plugin-debugger 1.24+dfsg-5 in amd64 (Release) |
|
@fastfading Please don't spam the trackers. The issue is reported and the author might be able to fix it. Or maybe somebody else is able to do so. |
|
Is this ready for merging? |
|
(BTW, I have other work to clean up all the GDB parsing code, which while quite a huge set of changes should avoid most possibilities of crashes in this area when GDB gives unexpected answers) |
|
OK. Going to merge and we will see ;) |
frlan
added a commit
that referenced
this pull request
Feb 19, 2015
debugger: Fix crash with GDB 7.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GDB 7.7 doesn't understand
&as an argument to-exec-run.Moreover, the code handling errors from GDB has an issue with this
error and leads to a crash.
Closes https://sourceforge.net/p/geany-plugins/bugs/112/
@cesspit Are you OK with this? I think it's important to do something as it leads to a crash when using GDB 7.7 (version is according to your findings). I also think that even if it prevents asynchronous debugging, it's still worth to fix until a proper asynchronous fix is released.