Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treebrowser fixes #3

Merged
merged 5 commits into from
Dec 30, 2011
Merged

Treebrowser fixes #3

merged 5 commits into from
Dec 30, 2011

Conversation

ndbroadbent
Copy link
Contributor

Fixed four issues for the Treebrowser plugin. See the commits in parantheses for details.

  1. When right-clicking on a file or directory, that file or directory should become selected before the context menu is shown. Previously, the user had to left-click first, before right-clicking. (46e40edc + 67c7ad1f)
  2. When renaming a file, you should not show the 'do you really want to replace it?' warning message if the filename has not changed. (d8059a4d)
  3. If I create an empty directory, then highlight '(Empty)' and right click it, the 'Create new directory' and 'Create new file' commands do nothing. (7c55f34)
  4. Files were created with 0755 (-rwxr-xr-x) permissions when they should be 0644 (-rw-r--r--). (f2e9232e)

Here are the corresponding SourceForge tickets:

Cheers,
Nathan

@ndbroadbent
Copy link
Contributor Author

Please note: After I submitted the pull request, I found a bug in my 'right-click' fix that broke directory collapse/expand. I've just added a new commit to fix this (67c7ad1).

@ndbroadbent
Fixed right-click for TreeBrowser. Must select the clicked row before…
0b2f92b 
… fetching name & URI from selection.
@ndbroadbent
Don't show 'replace file' warning if the filename hasn't changed.
39455de
@ndbroadbent
Fixed the 'create new object' context menu action, when right clickin…
fe0d7a3 
…g an '(Empty)' item in a directory. '(Empty)' rows have a NULL uri, so 'g_path_get_dirname(uri)' didn't work. This was replaced with a call to 'gtk_tree_model_get', so that it updates the uri from the parent node.
@ndbroadbent
When creating a new file, permissions should be 0644. Only new direct…
42d4359 
…ories should be 0755.
@ndbroadbent
Corrected the 'right-click' fix. Only select row on a rightclick, not…
5c5dfa9 
… on all clicks. Otherwise collapse/expand on a directory doesn't work properly.
@ndbroadbent
Copy link
Contributor Author

I've rebased my commits onto the new master revision, after my gitignore branch was merged

frlan added a commit that referenced this pull request Dec 30, 2011
@frlan
Merge pull request #3 from ndbroadbent/treebrowser_fixes
e1c5007 
Several treebrowser fixes and improvements
@frlan frlan merged commit e1c5007 into geany:master Dec 30, 2011
@frlan frlan mentioned this pull request Feb 20, 2015
Closed
@techee techee mentioned this pull request Jun 17, 2015
Closed
@xomrk xomrk mentioned this pull request Mar 15, 2016
Closed
@msaf1980 msaf1980 mentioned this pull request Jun 5, 2017
Closed
@Top-Dog Top-Dog mentioned this pull request Feb 25, 2018
Open
@bbrtj bbrtj mentioned this pull request May 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ndbroadbent @frlan