Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to hide the sidebar of geanyprj plugin #7

Closed
wants to merge 5 commits into from
Closed

Add ability to hide the sidebar of geanyprj plugin #7

wants to merge 5 commits into from

Conversation

cushy007
Copy link
Contributor

The sidebar of geanyprj plugin is almost unusable with large projects since it displays the flat files hierachy. This commit allows the user to configure wether or not to display it.

It uses plugin_configure and g_key_file to save the user's choice.
The default behavior is to display the sidebar so that actual users won't be lost.

Note: I am very new to Git and this is my first pull request. I hope I've done it right :)

- uses plugin_configure and g_key_file to save choice
- defaults to "display on" so that actual users don't see any difference
@frlan
Copy link
Member

frlan commented Jan 4, 2012

I have no idea atm. Did you check manual

@cushy007
Copy link
Contributor Author

cushy007 commented Jan 4, 2012

it's not clearly explained in the manual, but ooops, just in the line below :

"You can add more commits to this pull request by pushing to the e6a41b5 branch on cushy007/geany-plugins"

-> done

@cushy007
Copy link
Contributor Author

cushy007 commented Jan 6, 2012

fix up non related commit. Sorry for the noise but I could'nt find out how to remove it cleanly

@Yurand
Copy link
Member

Yurand commented Jan 8, 2012

I commited:
geanyprj: chose whether or not to display the sidebar
geanyprj: Save configuration as soon as configure event

I am not sure what is right way to handle pull requests, but I think that we generaly don't want junk commits in mainline: (like adding and reverting .geanyprj in .gitignore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants