cppcheck: Set Geany include path for it to find header files #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes build with recent versions of cppcheck with some plugins using PLUGIN_VERSION_CHECK() macro, like the latex plugin.
Implementation shamelessly copied over from pkg-config's pkg.m4, GPLv2+.
Implementation shamelessly copied over from Autoconf's m4sh.m4, GPLv3+.
…which was a good thing as apparently our CI has a too old pkg-config that doesn't provide |
|
LGBI |
b4n
commented
Feb 7, 2020
| m4_ifndef([AS_VAR_COPY], [ | ||
| m4_define([AS_VAR_COPY], | ||
| [AS_LITERAL_WORD_IF([$1[]$2], [$1=$$2], [eval $1=\$$2])]) | ||
| ]) |
There was a problem hiding this comment.
I'm not totally sure about this part: it might not be needed, and if it is I'm not sure AS_LITERAL_WORD_IF would be available. This code is what Autoconf has nowadays, but the inspiration I got from cryptsetup has AS_LITERAL_IF instead (but it seems to be buggy in some cases if I trust the documentation).
Anyway, we can fix this if a problem arises
b4n
added a commit
that referenced
this pull request
Feb 7, 2020
cppcheck: Set Geany include path for it to find header files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes build with recent versions of cppcheck with some plugins using
PLUGIN_VERSION_CHECK()macro, like the latex plugin.@eht16 already tested this with the nightly build environment, but I'm PRing this to make sure the CI tests here also pass. And extra review is always welcome ;)