Fixes an issue where removing with a query object would cause an error #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine. The RT code is going to be revamped for the next release anyhow. |
ben-ng
pushed a commit
that referenced
this pull request
Dec 14, 2013
Fixes an issue where removing with a query object would cause an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @zerocle for reporting this
Fixes this issue: https://github.com/zerocle/GeddyMultiDeleteError
Not yet merging this one in because I'm not sure if creating a copy of the argument is the best way to fix this.
Since model sends the object to the event handler, so there's the chance that the user (in this case geddy) changes that object and screws up what model expected.
Also, I feel like it should be model's job to perform the copy before passing it as an argument to emit.
Thoughts @mde?