Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Too many one-off checks for empty value #49

Closed
mde opened this Issue Mar 24, 2013 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

mde commented Mar 24, 2013

Check for "not empty string, not null, not undefined" is being done inline in multiple places. Make this all one single function call.

Contributor

lgomezma commented Mar 24, 2013

Indeed, otherwise it becomes too cumbersome. Where would it be the best place to define such function? I'm still getting used to model's architecture...

Contributor

mde commented Mar 26, 2013

I went ahead and added it to the utilities library, in the core, since it's general-purpose: mde/utilities@c5fcbb5

@mde mde closed this Mar 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment