Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many one-off checks for empty value #49

Closed
mde opened this issue Mar 24, 2013 · 2 comments
Closed

Too many one-off checks for empty value #49

mde opened this issue Mar 24, 2013 · 2 comments

Comments

@mde
Copy link
Contributor

mde commented Mar 24, 2013

Check for "not empty string, not null, not undefined" is being done inline in multiple places. Make this all one single function call.

@lgomezma
Copy link
Contributor

Indeed, otherwise it becomes too cumbersome. Where would it be the best place to define such function? I'm still getting used to model's architecture...

@mde
Copy link
Contributor Author

mde commented Mar 26, 2013

I went ahead and added it to the utilities library, in the core, since it's general-purpose: mde/utilities@c5fcbb5

@mde mde closed this as completed Mar 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants