Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rumour enum changes #32

Open
DapperMickie opened this issue May 15, 2024 · 0 comments
Open

Rumour enum changes #32

DapperMickie opened this issue May 15, 2024 · 0 comments
Assignees

Comments

@DapperMickie
Copy link
Collaborator

I would like to propose some changes to the Rumour enum, as in it's current state it has booleans for whether or not it's a novice, adept ...etc rumour.

However, these booleans are never actually used and don't make too much sense even if they were used.

Because even if some rumour is an adept rumour, it doesn't necessarily have to mean both adept hunters are able to assign these.

So what I'd propose us doing is change these booleans to be a list of possible hunters that can assign these rumours.
Which means that once we get our side panel up and running, we could add a tab that can list out these rumours per hunter (or vice versa).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant