Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockutil #106

Merged
merged 8 commits into from May 7, 2021
Merged

dockutil #106

merged 8 commits into from May 7, 2021

Conversation

dspolleke
Copy link
Contributor

Because upstream contributor does not respond I added the functionality and made it work.

  • fixed default (empty) variable
  • fixed some strong language
  • fixed the tags (added block)
  • used command in stead of shell where possible.
  • loop vs with_items
  • added the default icons that Apple installs on that mile wide dock on Big Sur

…variable, \ncreated block (for tags to work), \nFixed some strong language, \N fixed some shell / command preference (ansible-lint)
@geerlingguy
Copy link
Owner

Original PR for reference: #84

main.yml Outdated Show resolved Hide resolved
default.config.yml Outdated Show resolved Hide resolved
default.config.yml Outdated Show resolved Hide resolved
tasks/extra-packages.yml Outdated Show resolved Hide resolved
StephenBrown2 added a commit to StephenBrown2/mac-dev-playbook that referenced this pull request Apr 22, 2021
Include dockutil: geerlingguy#106
Include bootstrap from geerlingguy#96 (comment)
Use osx_defaults module: geerlingguy#79
@geerlingguy geerlingguy merged commit 97956cd into geerlingguy:master May 7, 2021
@geerlingguy
Copy link
Owner

Merged, but made sure nothing is changed by default, and also changed a few vars and styling for consistency.

kalopilato pushed a commit to kalopilato/mac-dev-playbook that referenced this pull request May 10, 2021
dspolleke pushed a commit to dspolleke/mac-dev-playbook that referenced this pull request May 26, 2021
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Mar 7, 2022
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Mar 7, 2022
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Mar 7, 2022
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Jan 23, 2024
fabiogomezdiaz pushed a commit to fabiogomezdiaz/mac-dev-playbook that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants