Fix incompability bug with Django 2.1 #343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For more information check this issue: geex-arts#342
2 tasks
|
I see we've been fixing the same bug. Sorry for blindly creating my pull request. Having said that, this version will raise an exception with Django versions < 2.1. See #345. |
|
@rense I would gladly close my issue and pull request to avoid duplication. Your code is much more safe and efficient ;) I'm new to Python tho, thanks to you, I learned a lot |
|
Close this pull request since #345 is better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information please check this issue: #342