Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Django 2.1 #714

Closed
2 tasks
philipbelesky opened this issue Aug 2, 2018 · 2 comments
Closed
2 tasks

Upgrade to Django 2.1 #714

philipbelesky opened this issue Aug 2, 2018 · 2 comments
Assignees
@philipbelesky
Labels
dependency
Milestone
LaPerm

Comments

@philipbelesky
Copy link
Member

philipbelesky commented Aug 2, 2018 •
edited
Loading

Brief thoughts from skimming release notes:

  • Fix compatibility with Jet
  • IIRC there are a few cases where we awkwardly get the full absolute url that could be switched to using HttpRequest.get_full_path_info()
@philipbelesky philipbelesky added this to the Khao Manee milestone Aug 2, 2018
@czlee
Copy link
Member

czlee commented Aug 2, 2018

Hmm, I think the "view permission" thing requires us to implement #131 to be useful. Our current practice is to make tab directors and CAs superusers, and having superuser access overrides all permissions anyway. (docs)

@philipbelesky
Copy link
Member Author

philipbelesky commented Aug 10, 2018 •
edited
Loading

Reopening this until this issue is merged and jet updated

@philipbelesky philipbelesky reopened this Aug 10, 2018
@philipbelesky philipbelesky self-assigned this Aug 10, 2018
@philipbelesky philipbelesky mentioned this issue Aug 19, 2018
Closed
@philipbelesky philipbelesky modified the milestones: Khao Manee, LaPerm Sep 1, 2018
philipbelesky added a commit that referenced this issue Sep 20, 2018
@philipbelesky
Merge branch 'feature/#714-django-2.1' into develop
52bc364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipbelesky philipbelesky

Labels
dependency
Projects
None yet
Milestone
LaPerm
Development

No branches or pull requests
2 participants
@philipbelesky @czlee