-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django 2.1 compatibility fix #345
Conversation
Skips adding 'sortable_by' arg for Django versions < 2.1
@f1nality is this PR will be approved? |
The code is fine. I can't fix an outdated build-configuration. I created an issue for this: #346 |
When can we expect this to get live? |
We can use another fork. |
@SalahAdDin Of course but I would prefer proper pypi release. |
We have no access to the official |
@SalahAdDin I know. For now I solved it by using rense's fork. |
Any update on this? We need this in the official pypi! |
@MaartenUreel i don't know, we are waiting for @f1nality |
OK, I purchased a commercial license, so I guess that's a feature request then :) |
@MaartenUreel i hope. |
If not I'll be filing a refund request at PayPal 😬 |
Thanks for PR! and sorry for delay |
It's an expensive PR ;-) But please keep up the good work and don't let this project go to waste. |
@MaartenUreel I'm sorry, they deprecate it. |
And is there any plans for a newer version or something then? Or just end of story? |
End of story unless a group of us wants to get together to fork it. |
@edmenendez, we tried before but the main responsible left me long time ago. |
Its not deprecated. Its just another vision on Jet. This project will continue to receive fixes for critical issues. Just no new features are planed (there was no new features long time already). |
Skips adding 'sortable_by' arg for Django versions < 2.1
Skips adding 'sortable_by' arg for Django versions < 2.1