Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 2.1 compatibility fix #345

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Django 2.1 compatibility fix #345

merged 1 commit into from
Oct 18, 2018

Conversation

rense
Copy link
Contributor

@rense rense commented Aug 11, 2018

Skips adding 'sortable_by' arg for Django versions < 2.1

Skips adding 'sortable_by' arg for Django versions < 2.1
@rense rense changed the title Django 2.1 compatability fix Django 2.1 compatibility fix Aug 11, 2018
@coveralls
Copy link

coveralls commented Aug 11, 2018

Coverage Status

Coverage increased (+0.09%) to 52.479% when pulling 2ec453a on rense:dev into cf3ceb8 on geex-arts:dev.

@SalahAdDin
Copy link
Contributor

@f1nality

@unittolabs
Copy link

@f1nality is this PR will be approved?

@verdan
Copy link

verdan commented Oct 1, 2018

@rense can you please make sure to fix the build so that @f1nality can approve and merge this PR? This is a blocker.

@rense
Copy link
Contributor Author

rense commented Oct 1, 2018

The code is fine. I can't fix an outdated build-configuration. I created an issue for this: #346

@riconnon riconnon mentioned this pull request Oct 2, 2018
@josefkorbel
Copy link

When can we expect this to get live?

@SalahAdDin
Copy link
Contributor

We can use another fork.

@josefkorbel
Copy link

@SalahAdDin Of course but I would prefer proper pypi release.

@SalahAdDin
Copy link
Contributor

We have no access to the official pypi file.

@josefkorbel
Copy link

@SalahAdDin I know. For now I solved it by using rense's fork.

@MaartenUreel
Copy link

Any update on this? We need this in the official pypi!

@SalahAdDin
Copy link
Contributor

@MaartenUreel i don't know, we are waiting for @f1nality

@MaartenUreel
Copy link

OK, I purchased a commercial license, so I guess that's a feature request then :)

@SalahAdDin
Copy link
Contributor

@MaartenUreel i hope.

@MaartenUreel
Copy link

If not I'll be filing a refund request at PayPal 😬

@f1nality f1nality merged commit 266b0ac into geex-arts:dev Oct 18, 2018
@f1nality
Copy link
Contributor

Thanks for PR! and sorry for delay

@MaartenUreel
Copy link

It's an expensive PR ;-) But please keep up the good work and don't let this project go to waste.

@SalahAdDin
Copy link
Contributor

@MaartenUreel I'm sorry, they deprecate it.

@MaartenUreel
Copy link

And is there any plans for a newer version or something then? Or just end of story?

@edmenendez
Copy link
Collaborator

End of story unless a group of us wants to get together to fork it.

@SalahAdDin
Copy link
Contributor

@edmenendez, we tried before but the main responsible left me long time ago.

@f1nality
Copy link
Contributor

f1nality commented Oct 19, 2018

Its not deprecated. Its just another vision on Jet. This project will continue to receive fixes for critical issues. Just no new features are planed (there was no new features long time already).

Abdoulrasheed pushed a commit to Abdoulrasheed/django-jet that referenced this pull request Mar 28, 2022
Skips adding 'sortable_by' arg for Django versions < 2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants