-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Image Quality for "Resizable Custom Crop" #12
Comments
Yap. Work in progress... On Sun, Mar 10, 2013 at 7:24 PM, Georg Kitz notifications@github.com
|
Any ETA on this? Thanks! |
@pathonhauser any news on that? |
Well ... 5 month now ... So, before I dive into GKImageCropView.m's croppedImage: is there already work done, will there be a solution anytime soon? Greetings |
found out something else, it apparently makes a huge difference in how the crop is done:
the former results in the noticed poor quality, the latter not. So maybe it's not the display size ... but the scale of the cropping rectangle. |
Hi there, Sry that it took so long. I just took a look at it and i think I found a solution. I'm going to make a pull request on the weekend because I'm really busy right now and I want to test it in depth. Can you wait till then or do you want me to post the code right here and you have to test it on your own? |
Well, as the colleague, which is doing the Server-side OCR-part also still has something to do - and is in holidays this and next week, I think it would be OK, when there's a tested solution on Monday, then I still can finish my part before he's back :-) Very Fine. |
What could I say ... hats off, great, brilliant, ...!!! |
Great to hear that you like it! :-) |
I think we can close it now. |
As the image quality of the custom crop was improved with the latest commit 2a91f31 we should definitely improve the quality of the "Resizeable Custom Crop" too.
@Pathonhauser, any ideas on that?
The text was updated successfully, but these errors were encountered: