Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for custom info (hibernation-warmup) and loading-screen messages #48

Closed
lubocode opened this issue Oct 15, 2020 · 6 comments
Labels
enhancement New feature or request request User's suggested enhancement

Comments

@lubocode
Copy link
Contributor

I think it’s related, so what about adding configuration for custom hibernation and startup messages? I modified the Python version for that until now but since it’s deprecated…

Sorry if it was already present or proposed.

Originally posted by @Br31zh in https://github.com/gekigek99/minecraft-server-hibernation/issue_comments/709141763

@lubocode lubocode added enhancement New feature or request request User's suggested enhancement labels Oct 15, 2020
@lubocode
Copy link
Contributor Author

lubocode commented Oct 15, 2020

I think it’s related, so what about adding configuration for custom hibernation and startup messages? I modified the Python version for that until now but since it’s deprecated…

Yes, we deprecated the Python Version simply because of too much overhead for maintenance.
We both use the Go version and as such, decided to deprecate the Python one.
However, this does not mean, that the Python version is now unusable. You can continue to use the last release and unless you run into bugs we have not found yet, it should work fine.

As for the go version; we plan to add instructions on how to build it by yourself, but basically it is a simple matter of installing go and running the command go build minecraft-server-hibernation.go in the script folder to create yourself an executable file from the code. Modifying the code should also not be too complicated, since you successfully did so in the Python version.

Copied answer from #30 (comment)

@gekigek99
Copy link
Member

basically it is a simple matter of installing go and running the command go build minecraft-server-hibernation.go in the script folder to create yourself an executable file from the code.

@Br31zh exacly, as a plus in next releases will include a compiled binary (no go installation stuff 😉) and I'm thinking about adding more config options in the .json file to increase configurability

@Br31zh
Copy link

Br31zh commented Oct 15, 2020

Of course, it was a bad formulation, even if you hadn’t stop maintaining the Python version it’s still a good idea to permit to change that from the configuration ^^ Changing the source code is a temporary workaround.

@gekigek99 gekigek99 changed the title Add configuration for custom hibernation and startup messages Add configuration for custom info (hibernation-warmup) and loading-screen messages Oct 15, 2020
@gekigek99
Copy link
Member

Add configuration for custom info (hibernation-warmup) where added in a7cc6c0.

configuration for custom loading-screen messages where not added since there is a %d in the string which cal lead to problems if omitted

@lubocode
Copy link
Contributor Author

configuration for custom loading-screen messages where not added since there is a %d in the string which cal lead to problems if omitted

@gekigek99 The string from the config could be combined with a string in the script for the countdown though?
Also, when #37 is built in, the countdown requirements might change.

@gekigek99
Copy link
Member

Oh yes... You are right!

I will figure it out when I add this functionality (since I think it more important than a silly configurable string)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request request User's suggested enhancement
Projects
None yet
Development

No branches or pull requests

3 participants