Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we replace round with numpy.round? #9542

Closed
micheles opened this issue Mar 21, 2024 · 1 comment
Closed

Should we replace round with numpy.round? #9542

micheles opened this issue Mar 21, 2024 · 1 comment
Assignees
@micheles
Labels
internal
Milestone
Engine 3.20.0

Comments

@micheles
Copy link
Contributor

micheles commented Mar 21, 2024 •
edited
Loading

We would need an AST-based test forbidding bare round. Notice that we have many occurrences of
from openquake.baselib.python3compat import round that cannot be removed without breaking a lot of tests.
@micheles micheles added this to the Engine 3.20.0 milestone Mar 21, 2024
@micheles micheles self-assigned this Mar 21, 2024
This was referenced Apr 18, 2024
Merged
Merged
@micheles
Copy link
Contributor Author

It is better to give up, since changing the rounding breaks the AELO tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@micheles micheles

Labels
internal
Projects
None yet
Milestone
Engine 3.20.0
Development

No branches or pull requests
1 participant
@micheles