Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"util/cpt_upgrader.py" not updating RISC-V checkpoints from v23.0.0.1 to changes in #83 #106

Closed
BobbyRBruce opened this issue Jul 20, 2023 · 1 comment · Fixed by #115
Closed

"util/cpt_upgrader.py" not updating RISC-V checkpoints from v23.0.0.1 to changes in #83 #106

BobbyRBruce opened this issue Jul 20, 2023 · 1 comment · Fixed by #115
Labels
arch-riscv The RISC-V ISA bug util Utilities for gem5. Typically found in "util"

Comments

@BobbyRBruce
Copy link
Member

To reproduce:

# Obtain the gem5 repo
git clone https://github.com/gem5/gem5.git
cd gem5

# Obtain the #83 PR
git fetch origin pull/83/head:rvv
git switch rvv

wget http://dist.gem5.org/dist/develop/checkpoints/riscv-hello-example-checkpoint-20230222.tar
mkdir checkpoint
tar xf riscv-hello-example-checkpoint-20230222.tar -C checkpoint/
./util/cpt_upgrader.py -v checkpoint

The following output is returned:

Processing file checkpoint/m5.cpt.... 

has tags arm-miscreg-teehbr arm-ccregs arm-gem5-gic-ext dvfs-perflevel x86-add-tlb ide-dma-abort remove-arm-cpsr-mode-miscreg etherswitch armv8 register-files ruby-block-size-bytes mempool-to-seworkload process-fdmap-rename cpu-pid globals-to-root smt-interrupts memory-per-range mempool-sections isa-is-simobject arm-sysreg-mapping-ns arm-contextidr-el2 multiple-event-queues arm-hdlcd-upgrade arm-sve arm-gicv2-banked-regs 

...nothing to do

I have only proven this fault when working with #83 for updating a checkpoint from v23.0.0.1 to that necessary for the PR. The limitation of "util/cpt_upgrader.py" may exist elsewhere.
@BobbyRBruce BobbyRBruce added util Utilities for gem5. Typically found in "util" arch-riscv The RISC-V ISA labels Jul 20, 2023
@BobbyRBruce BobbyRBruce mentioned this issue Jul 20, 2023
Merged
aarmejach pushed a commit to aarmejach/gem5 that referenced this issue Jul 24, 2023
@adriaarmejach
util: fix cpt upgrader for rvv changes in PR gem5#83
5ed4967 
  * Solves issue gem5#106 by updating the cpts with the necessary vector
    registers.

Change-Id: Ifeda90e96097f0b0a65338c6b22a8258c932c585
@aarmejach aarmejach mentioned this issue Jul 24, 2023
Merged
@BobbyRBruce BobbyRBruce linked a pull request Jul 24, 2023 that will close this issue
util: fix cpt upgrader for rvv changes in PR #83 #115
Merged
aarmejach pushed a commit to aarmejach/gem5 that referenced this issue Jul 28, 2023
@adriaarmejach
util: fix cpt upgrader for rvv changes in PR gem5#83
ae5a85f 
  * Solves issue gem5#106 by updating the cpts with the necessary vector
    registers.

Change-Id: Ifeda90e96097f0b0a65338c6b22a8258c932c585

util: clear vector_element field

Change-Id: I6c9ec4e71f66722b26de030fa139cd626bdb24dc
aarmejach pushed a commit to aarmejach/gem5 that referenced this issue Aug 4, 2023
@adriaarmejach
util: fix cpt upgrader for rvv changes in PR gem5#83
f777cc1 
  * Solves issue gem5#106 by updating the cpts with the necessary vector
    registers.

Change-Id: Ifeda90e96097f0b0a65338c6b22a8258c932c585

util: clear vector_element field

Change-Id: I6c9ec4e71f66722b26de030fa139cd626bdb24dc
powerjg added a commit that referenced this issue Aug 4, 2023
@powerjg
util: fix cpt upgrader for rvv changes in PR #83 (#115)
ed44df5 
Solves issue #106 by updating the cpts with the necessary vector
registers.
alvaromorenomv pushed a commit to alvaromorenomv/gem5 that referenced this issue Aug 9, 2023
@adriaarmejach
util: fix cpt upgrader for rvv changes in PR gem5#83
fe745f4 
  * Solves issue gem5#106 by updating the cpts with the necessary vector
    registers.

Change-Id: Ifeda90e96097f0b0a65338c6b22a8258c932c585

util: clear vector_element field

Change-Id: I6c9ec4e71f66722b26de030fa139cd626bdb24dc
@powerjg
Copy link
Contributor

powerjg commented Aug 10, 2023

@BobbyRBruce can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-riscv The RISC-V ISA bug util Utilities for gem5. Typically found in "util"
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

util: fix cpt upgrader for rvv changes in PR #83 aarmejach/gem5
2 participants
@powerjg @BobbyRBruce