Segmentation fault when running with invalid frontend name #28
Comments
|
Thanks for the detailed report. It is not a regression in 3.10.0 but a legacy issue no one tested ever. Nevertheless, consider it fixed soon. |
|
Thanks so much for getting to this quickly and for continuing this project!
…On Sat, Feb 17, 2024 at 3:11 AM Gemba ***@***.***> wrote:
Closed #28 <#28> as completed
via d4c2d61
<d4c2d61>
.
—
Reply to this email directly, view it on GitHub
<#28 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGB6T2YDH4ZX4QRSJ7LKP2LYUBQZRAVCNFSM6AAAAABDDYUPACVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRHAZTKOBXHE2TENA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
maxexcloo
pushed a commit
to maxexcloo/skyscraper
that referenced
this issue
Feb 21, 2024
* simplified code with predefined function * Fix Gemba#28 Fix cont. integration workflo (Gemba#33) * update package index before install Scummvm: Changes to generate a ROM folder.svm/ as <game/> launcher instead of folder. (Gemba#35) * Scummvm: Changes to generate a ROM `folder.svm/` as `<game/>` launcher instead of folder.
retrobit
pushed a commit
to retrobit/skyscraper
that referenced
this issue
Mar 4, 2024
* simplified code with predefined function * Fix Gemba#28
retrobit
pushed a commit
to retrobit/skyscraper
that referenced
this issue
Mar 4, 2024
* simplified code with predefined function * Fix Gemba#28
retrobit
added a commit
to retrobit/skyscraper
that referenced
this issue
Mar 4, 2024
Don't build/install Skyscraper after dev container build Configure git for dev container Updated `devcontainer.json` and `.devcontainer/Dockerfile` Updated `.devcontainer` and added `build.sh` for easy building Added `postCreateCommand.sh` for additional Dev Container configuration Generalized ROM directory created in `postCreateCommand.sh` away from VSCode Moved `postCreateCommand.sh` to `.devcontainer` `postCreateCommand.sh` - Commented-out troublesome default `git` configuration; kept as still useful at developer's discretion platform psp: added *.chd Rel 3.10.0 (Gemba#26) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type Rel 3.10.0 (Gemba#27) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type * Version 3.10.0 Fix issue 28 (Gemba#32) * simplified code with predefined function * Fix Gemba#28 Fix cont. integration workflo (Gemba#33) * update package index before install postCreateCommand.sh - Commented-out troublesome default configuration; still useful at developer's discretion
retrobit
added a commit
to retrobit/skyscraper
that referenced
this issue
Mar 4, 2024
Updated `aliasMap.csv` comments platform psp: added *.chd Dev Container support w/Dockerfile (Gemba#23) Co-authored-by: retrobit <6226450+retrobit@users.noreply.github.com> Rel 3.10.0 (Gemba#26) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type Rel 3.10.0 (Gemba#27) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type * Version 3.10.0 Fix issue 28 (Gemba#32) * simplified code with predefined function * Fix Gemba#28 Fix cont. integration workflo (Gemba#33) * update package index before install Being pedantic/consistent Pedantic/clarifying/consistent Removed file used for testing Reverted ES Game List scraper - doesn't make sense to use `aliasMap.csv` with this scraper Not sure why this keeps getting added... I avoid staging it purposefully. Removed. Scummvm: Changes to generate a ROM folder.svm/ as <game/> launcher instead of folder. (Gemba#35) * Scummvm: Changes to generate a ROM `folder.svm/` as `<game/>` launcher instead of folder. update README Update from RetroPie Project (2024-02-22) cf. RetroPie/EmulationStation#866 Cpp Std 17 Add new platforms (Gemba#37) Updated platforms_idmap.csv and peas.json Update docs: - Removed passages about creating a symlink on RetroPie (now part of the scriptmodule). - Edit paragraph about bash_completion on RetroPie Fix Gemba#38 (Gemba#43) Plus cornercase solved: When default ES inputFolder is symlinked from /home/pi/RetroPie/roms to /home/pi/roms f.i. and user provides from that symlink downwards rom files on CLI. Version 3.10.2
retrobit
added a commit
to retrobit/skyscraper
that referenced
this issue
Mar 4, 2024
Updated `aliasMap.csv` comments platform psp: added *.chd Dev Container support w/Dockerfile (Gemba#23) Co-authored-by: retrobit <6226450+retrobit@users.noreply.github.com> Rel 3.10.0 (Gemba#26) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type Rel 3.10.0 (Gemba#27) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type * Version 3.10.0 Fix issue 28 (Gemba#32) * simplified code with predefined function * Fix Gemba#28 Fix cont. integration workflo (Gemba#33) * update package index before install Being pedantic/consistent Pedantic/clarifying/consistent Removed file used for testing Reverted ES Game List scraper - doesn't make sense to use `aliasMap.csv` with this scraper Not sure why this keeps getting added... I avoid staging it purposefully. Removed. Scummvm: Changes to generate a ROM folder.svm/ as <game/> launcher instead of folder. (Gemba#35) * Scummvm: Changes to generate a ROM `folder.svm/` as `<game/>` launcher instead of folder. update README Update from RetroPie Project (2024-02-22) cf. RetroPie/EmulationStation#866 Cpp Std 17 Add new platforms (Gemba#37) Updated platforms_idmap.csv and peas.json Update docs: - Removed passages about creating a symlink on RetroPie (now part of the scriptmodule). - Edit paragraph about bash_completion on RetroPie Fix Gemba#38 (Gemba#43) Plus cornercase solved: When default ES inputFolder is symlinked from /home/pi/RetroPie/roms to /home/pi/roms f.i. and user provides from that symlink downwards rom files on CLI. Version 3.10.2
retrobit
added a commit
to retrobit/skyscraper
that referenced
this issue
Mar 4, 2024
Don't build/install Skyscraper after dev container build Configure git for dev container Updated `devcontainer.json` and `.devcontainer/Dockerfile` Updated `.devcontainer` and added `build.sh` for easy building Added `postCreateCommand.sh` for additional Dev Container configuration Generalized ROM directory created in `postCreateCommand.sh` away from VSCode Moved `postCreateCommand.sh` to `.devcontainer` `postCreateCommand.sh` - Commented-out troublesome default `git` configuration; kept as still useful at developer's discretion platform psp: added *.chd Rel 3.10.0 (Gemba#26) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type Rel 3.10.0 (Gemba#27) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type * Version 3.10.0 Fix issue 28 (Gemba#32) * simplified code with predefined function * Fix Gemba#28 Fix cont. integration workflo (Gemba#33) * update package index before install postCreateCommand.sh - Commented-out troublesome default configuration; still useful at developer's discretion
retrobit
added a commit
to retrobit/skyscraper
that referenced
this issue
Mar 4, 2024
Updated `aliasMap.csv` comments platform psp: added *.chd Dev Container support w/Dockerfile (Gemba#23) Co-authored-by: retrobit <6226450+retrobit@users.noreply.github.com> Rel 3.10.0 (Gemba#26) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type Rel 3.10.0 (Gemba#27) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type * Version 3.10.0 Fix issue 28 (Gemba#32) * simplified code with predefined function * Fix Gemba#28 Fix cont. integration workflo (Gemba#33) * update package index before install Being pedantic/consistent Pedantic/clarifying/consistent Removed file used for testing Reverted ES Game List scraper - doesn't make sense to use `aliasMap.csv` with this scraper Not sure why this keeps getting added... I avoid staging it purposefully. Removed. Scummvm: Changes to generate a ROM folder.svm/ as <game/> launcher instead of folder. (Gemba#35) * Scummvm: Changes to generate a ROM `folder.svm/` as `<game/>` launcher instead of folder. update README Update from RetroPie Project (2024-02-22) cf. RetroPie/EmulationStation#866 Cpp Std 17 Add new platforms (Gemba#37) Updated platforms_idmap.csv and peas.json Update docs: - Removed passages about creating a symlink on RetroPie (now part of the scriptmodule). - Edit paragraph about bash_completion on RetroPie Fix Gemba#38 (Gemba#43) Plus cornercase solved: When default ES inputFolder is symlinked from /home/pi/RetroPie/roms to /home/pi/roms f.i. and user provides from that symlink downwards rom files on CLI. Version 3.10.2
retrobit
added a commit
to retrobit/skyscraper
that referenced
this issue
Mar 4, 2024
Updated `aliasMap.csv` comments platform psp: added *.chd Dev Container support w/Dockerfile (Gemba#23) Co-authored-by: retrobit <6226450+retrobit@users.noreply.github.com> Rel 3.10.0 (Gemba#26) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type Rel 3.10.0 (Gemba#27) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type * Version 3.10.0 Fix issue 28 (Gemba#32) * simplified code with predefined function * Fix Gemba#28 Fix cont. integration workflo (Gemba#33) * update package index before install Being pedantic/consistent Pedantic/clarifying/consistent Removed file used for testing Reverted ES Game List scraper - doesn't make sense to use `aliasMap.csv` with this scraper Not sure why this keeps getting added... I avoid staging it purposefully. Removed. Scummvm: Changes to generate a ROM folder.svm/ as <game/> launcher instead of folder. (Gemba#35) * Scummvm: Changes to generate a ROM `folder.svm/` as `<game/>` launcher instead of folder. update README Update from RetroPie Project (2024-02-22) cf. RetroPie/EmulationStation#866 Cpp Std 17 Add new platforms (Gemba#37) Updated platforms_idmap.csv and peas.json Update docs: - Removed passages about creating a symlink on RetroPie (now part of the scriptmodule). - Edit paragraph about bash_completion on RetroPie Fix Gemba#38 (Gemba#43) Plus cornercase solved: When default ES inputFolder is symlinked from /home/pi/RetroPie/roms to /home/pi/roms f.i. and user provides from that symlink downwards rom files on CLI. Version 3.10.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
If you supply an invalid frontend name in the config file or via the command line, Skyscraper ungracefully crashes with the message "Segmentation fault (core dumped)"
Note this happens even if you supply the write frontend name but with the wrong case.
To Reproduce
Run Skyscraper with an invalid frontend. For example:
Skyscraper -p snes -s screenscraper -f PegasusExpected behavior
We should tell the user the frontend is invalid, and perhaps print out a list of valid names
Special circumstances
This was running Linux Mint which is case sensitive for many more things than other platforms like Windows might be. But this probably not due to filesystem case sensitivity.
Technical information
The text was updated successfully, but these errors were encountered: