Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #38 #43

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Fix #38 #43

merged 1 commit into from
Feb 27, 2024

Conversation

Gemba
Copy link
Owner

@Gemba Gemba commented Feb 27, 2024

Plus cornercase solved: When default ES inputFolder is symlinked from /home/pi/RetroPie/roms to /home/pi/roms f.i. and user provides from that symlink downwards rom files on CLI.

Plus cornercase solved: When default ES inputFolder is symlinked from
/home/pi/RetroPie/roms to /home/pi/roms f.i. and user provides from that symlink
downwards rom files on CLI.
@Gemba Gemba merged commit 597be95 into master Feb 27, 2024
2 checks passed
retrobit pushed a commit to retrobit/skyscraper that referenced this pull request Mar 4, 2024
Plus cornercase solved: When default ES inputFolder is symlinked from
/home/pi/RetroPie/roms to /home/pi/roms f.i. and user provides from that symlink
downwards rom files on CLI.
retrobit added a commit to retrobit/skyscraper that referenced this pull request Mar 4, 2024
Updated `aliasMap.csv` comments

platform psp: added *.chd

Dev Container support w/Dockerfile (Gemba#23)

Co-authored-by: retrobit <6226450+retrobit@users.noreply.github.com>

Rel 3.10.0 (Gemba#26)

* simplified bash completion with built-in/provided functions...

plus:
- qmake: user defined install path
- doc: minor enhancements

* Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type

Rel 3.10.0 (Gemba#27)

* simplified bash completion with built-in/provided functions...

plus:
- qmake: user defined install path
- doc: minor enhancements

* Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type

* Version 3.10.0

Fix issue 28 (Gemba#32)

* simplified code with predefined function

* Fix Gemba#28

Fix cont. integration workflo (Gemba#33)

* update package index before install

Being pedantic/consistent

Pedantic/clarifying/consistent

Removed file used for testing

Reverted ES Game List scraper - doesn't make sense to use `aliasMap.csv` with this scraper

Not sure why this keeps getting added... I avoid staging it purposefully. Removed.

Scummvm: Changes to generate a ROM folder.svm/ as <game/> launcher instead of folder. (Gemba#35)

* Scummvm: Changes to generate a ROM `folder.svm/` as `<game/>` launcher instead of folder.

update README

Update from RetroPie Project (2024-02-22)

cf. RetroPie/EmulationStation#866

Cpp Std 17

Add new platforms (Gemba#37)

Updated platforms_idmap.csv and peas.json

Update docs:

- Removed passages about creating a symlink on RetroPie (now part of the scriptmodule).
- Edit paragraph about bash_completion on RetroPie

Fix Gemba#38 (Gemba#43)

Plus cornercase solved: When default ES inputFolder is symlinked from
/home/pi/RetroPie/roms to /home/pi/roms f.i. and user provides from that symlink
downwards rom files on CLI.

Version 3.10.2
retrobit added a commit to retrobit/skyscraper that referenced this pull request Mar 4, 2024
Updated `aliasMap.csv` comments

platform psp: added *.chd

Dev Container support w/Dockerfile (Gemba#23)

Co-authored-by: retrobit <6226450+retrobit@users.noreply.github.com>

Rel 3.10.0 (Gemba#26)

* simplified bash completion with built-in/provided functions...

plus:
- qmake: user defined install path
- doc: minor enhancements

* Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type

Rel 3.10.0 (Gemba#27)

* simplified bash completion with built-in/provided functions...

plus:
- qmake: user defined install path
- doc: minor enhancements

* Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type

* Version 3.10.0

Fix issue 28 (Gemba#32)

* simplified code with predefined function

* Fix Gemba#28

Fix cont. integration workflo (Gemba#33)

* update package index before install

Being pedantic/consistent

Pedantic/clarifying/consistent

Removed file used for testing

Reverted ES Game List scraper - doesn't make sense to use `aliasMap.csv` with this scraper

Not sure why this keeps getting added... I avoid staging it purposefully. Removed.

Scummvm: Changes to generate a ROM folder.svm/ as <game/> launcher instead of folder. (Gemba#35)

* Scummvm: Changes to generate a ROM `folder.svm/` as `<game/>` launcher instead of folder.

update README

Update from RetroPie Project (2024-02-22)

cf. RetroPie/EmulationStation#866

Cpp Std 17

Add new platforms (Gemba#37)

Updated platforms_idmap.csv and peas.json

Update docs:

- Removed passages about creating a symlink on RetroPie (now part of the scriptmodule).
- Edit paragraph about bash_completion on RetroPie

Fix Gemba#38 (Gemba#43)

Plus cornercase solved: When default ES inputFolder is symlinked from
/home/pi/RetroPie/roms to /home/pi/roms f.i. and user provides from that symlink
downwards rom files on CLI.

Version 3.10.2
retrobit added a commit to retrobit/skyscraper that referenced this pull request Mar 4, 2024
Updated `aliasMap.csv` comments

platform psp: added *.chd

Dev Container support w/Dockerfile (Gemba#23)

Co-authored-by: retrobit <6226450+retrobit@users.noreply.github.com>

Rel 3.10.0 (Gemba#26)

* simplified bash completion with built-in/provided functions...

plus:
- qmake: user defined install path
- doc: minor enhancements

* Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type

Rel 3.10.0 (Gemba#27)

* simplified bash completion with built-in/provided functions...

plus:
- qmake: user defined install path
- doc: minor enhancements

* Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type

* Version 3.10.0

Fix issue 28 (Gemba#32)

* simplified code with predefined function

* Fix Gemba#28

Fix cont. integration workflo (Gemba#33)

* update package index before install

Being pedantic/consistent

Pedantic/clarifying/consistent

Removed file used for testing

Reverted ES Game List scraper - doesn't make sense to use `aliasMap.csv` with this scraper

Not sure why this keeps getting added... I avoid staging it purposefully. Removed.

Scummvm: Changes to generate a ROM folder.svm/ as <game/> launcher instead of folder. (Gemba#35)

* Scummvm: Changes to generate a ROM `folder.svm/` as `<game/>` launcher instead of folder.

update README

Update from RetroPie Project (2024-02-22)

cf. RetroPie/EmulationStation#866

Cpp Std 17

Add new platforms (Gemba#37)

Updated platforms_idmap.csv and peas.json

Update docs:

- Removed passages about creating a symlink on RetroPie (now part of the scriptmodule).
- Edit paragraph about bash_completion on RetroPie

Fix Gemba#38 (Gemba#43)

Plus cornercase solved: When default ES inputFolder is symlinked from
/home/pi/RetroPie/roms to /home/pi/roms f.i. and user provides from that symlink
downwards rom files on CLI.

Version 3.10.2
retrobit added a commit to retrobit/skyscraper that referenced this pull request Mar 4, 2024
Updated `aliasMap.csv` comments

platform psp: added *.chd

Dev Container support w/Dockerfile (Gemba#23)

Co-authored-by: retrobit <6226450+retrobit@users.noreply.github.com>

Rel 3.10.0 (Gemba#26)

* simplified bash completion with built-in/provided functions...

plus:
- qmake: user defined install path
- doc: minor enhancements

* Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type

Rel 3.10.0 (Gemba#27)

* simplified bash completion with built-in/provided functions...

plus:
- qmake: user defined install path
- doc: minor enhancements

* Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type

* Version 3.10.0

Fix issue 28 (Gemba#32)

* simplified code with predefined function

* Fix Gemba#28

Fix cont. integration workflo (Gemba#33)

* update package index before install

Being pedantic/consistent

Pedantic/clarifying/consistent

Removed file used for testing

Reverted ES Game List scraper - doesn't make sense to use `aliasMap.csv` with this scraper

Not sure why this keeps getting added... I avoid staging it purposefully. Removed.

Scummvm: Changes to generate a ROM folder.svm/ as <game/> launcher instead of folder. (Gemba#35)

* Scummvm: Changes to generate a ROM `folder.svm/` as `<game/>` launcher instead of folder.

update README

Update from RetroPie Project (2024-02-22)

cf. RetroPie/EmulationStation#866

Cpp Std 17

Add new platforms (Gemba#37)

Updated platforms_idmap.csv and peas.json

Update docs:

- Removed passages about creating a symlink on RetroPie (now part of the scriptmodule).
- Edit paragraph about bash_completion on RetroPie

Fix Gemba#38 (Gemba#43)

Plus cornercase solved: When default ES inputFolder is symlinked from
/home/pi/RetroPie/roms to /home/pi/roms f.i. and user provides from that symlink
downwards rom files on CLI.

Version 3.10.2
@Gemba Gemba deleted the fix_issue_38 branch April 3, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant