Added New Platforms #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, can you please squash/rebase the commits to one? |
|
Will try! |
Update platforms_idmap.csv
maxexcloo
force-pushed
the
master
branch
2 times, most recently
from
ee73aba
to
f5e7434
Compare
|
Is it okay now? Haven't done a squash before so do let me know and I'll try again :) |
|
Almost. I accidentally put the 3.10.0 tag on the branch before I merged in my repo, sorry. Thus your squash does not look as it should. From the distance, I would vote for this approach:
If it is too much, leave it with me: I can put your changes in outside of this PR, too. |
|
No that’s a really nice guide and I really appreciate the help - always grateful for someone who shows me how to do something properly so I can improve 🙏 I’ll have a go at that this morning! |
|
I see there are still merges from your repo - is this okay? |
|
Thanks. These extra commits are ok. As instant feedback, below is what I get presented before the merge (1 commit and only your changes):
|
retrobit
pushed a commit
to retrobit/skyscraper
that referenced
this pull request
Mar 4, 2024
Updated platforms_idmap.csv and peas.json
retrobit
added a commit
to retrobit/skyscraper
that referenced
this pull request
Mar 4, 2024
Updated `aliasMap.csv` comments platform psp: added *.chd Dev Container support w/Dockerfile (Gemba#23) Co-authored-by: retrobit <6226450+retrobit@users.noreply.github.com> Rel 3.10.0 (Gemba#26) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type Rel 3.10.0 (Gemba#27) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type * Version 3.10.0 Fix issue 28 (Gemba#32) * simplified code with predefined function * Fix Gemba#28 Fix cont. integration workflo (Gemba#33) * update package index before install Being pedantic/consistent Pedantic/clarifying/consistent Removed file used for testing Reverted ES Game List scraper - doesn't make sense to use `aliasMap.csv` with this scraper Not sure why this keeps getting added... I avoid staging it purposefully. Removed. Scummvm: Changes to generate a ROM folder.svm/ as <game/> launcher instead of folder. (Gemba#35) * Scummvm: Changes to generate a ROM `folder.svm/` as `<game/>` launcher instead of folder. update README Update from RetroPie Project (2024-02-22) cf. RetroPie/EmulationStation#866 Cpp Std 17 Add new platforms (Gemba#37) Updated platforms_idmap.csv and peas.json Update docs: - Removed passages about creating a symlink on RetroPie (now part of the scriptmodule). - Edit paragraph about bash_completion on RetroPie Fix Gemba#38 (Gemba#43) Plus cornercase solved: When default ES inputFolder is symlinked from /home/pi/RetroPie/roms to /home/pi/roms f.i. and user provides from that symlink downwards rom files on CLI. Version 3.10.2
retrobit
added a commit
to retrobit/skyscraper
that referenced
this pull request
Mar 4, 2024
Updated `aliasMap.csv` comments platform psp: added *.chd Dev Container support w/Dockerfile (Gemba#23) Co-authored-by: retrobit <6226450+retrobit@users.noreply.github.com> Rel 3.10.0 (Gemba#26) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type Rel 3.10.0 (Gemba#27) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type * Version 3.10.0 Fix issue 28 (Gemba#32) * simplified code with predefined function * Fix Gemba#28 Fix cont. integration workflo (Gemba#33) * update package index before install Being pedantic/consistent Pedantic/clarifying/consistent Removed file used for testing Reverted ES Game List scraper - doesn't make sense to use `aliasMap.csv` with this scraper Not sure why this keeps getting added... I avoid staging it purposefully. Removed. Scummvm: Changes to generate a ROM folder.svm/ as <game/> launcher instead of folder. (Gemba#35) * Scummvm: Changes to generate a ROM `folder.svm/` as `<game/>` launcher instead of folder. update README Update from RetroPie Project (2024-02-22) cf. RetroPie/EmulationStation#866 Cpp Std 17 Add new platforms (Gemba#37) Updated platforms_idmap.csv and peas.json Update docs: - Removed passages about creating a symlink on RetroPie (now part of the scriptmodule). - Edit paragraph about bash_completion on RetroPie Fix Gemba#38 (Gemba#43) Plus cornercase solved: When default ES inputFolder is symlinked from /home/pi/RetroPie/roms to /home/pi/roms f.i. and user provides from that symlink downwards rom files on CLI. Version 3.10.2
retrobit
added a commit
to retrobit/skyscraper
that referenced
this pull request
Mar 4, 2024
Updated `aliasMap.csv` comments platform psp: added *.chd Dev Container support w/Dockerfile (Gemba#23) Co-authored-by: retrobit <6226450+retrobit@users.noreply.github.com> Rel 3.10.0 (Gemba#26) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type Rel 3.10.0 (Gemba#27) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type * Version 3.10.0 Fix issue 28 (Gemba#32) * simplified code with predefined function * Fix Gemba#28 Fix cont. integration workflo (Gemba#33) * update package index before install Being pedantic/consistent Pedantic/clarifying/consistent Removed file used for testing Reverted ES Game List scraper - doesn't make sense to use `aliasMap.csv` with this scraper Not sure why this keeps getting added... I avoid staging it purposefully. Removed. Scummvm: Changes to generate a ROM folder.svm/ as <game/> launcher instead of folder. (Gemba#35) * Scummvm: Changes to generate a ROM `folder.svm/` as `<game/>` launcher instead of folder. update README Update from RetroPie Project (2024-02-22) cf. RetroPie/EmulationStation#866 Cpp Std 17 Add new platforms (Gemba#37) Updated platforms_idmap.csv and peas.json Update docs: - Removed passages about creating a symlink on RetroPie (now part of the scriptmodule). - Edit paragraph about bash_completion on RetroPie Fix Gemba#38 (Gemba#43) Plus cornercase solved: When default ES inputFolder is symlinked from /home/pi/RetroPie/roms to /home/pi/roms f.i. and user provides from that symlink downwards rom files on CLI. Version 3.10.2
retrobit
added a commit
to retrobit/skyscraper
that referenced
this pull request
Mar 4, 2024
Updated `aliasMap.csv` comments platform psp: added *.chd Dev Container support w/Dockerfile (Gemba#23) Co-authored-by: retrobit <6226450+retrobit@users.noreply.github.com> Rel 3.10.0 (Gemba#26) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type Rel 3.10.0 (Gemba#27) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type * Version 3.10.0 Fix issue 28 (Gemba#32) * simplified code with predefined function * Fix Gemba#28 Fix cont. integration workflo (Gemba#33) * update package index before install Being pedantic/consistent Pedantic/clarifying/consistent Removed file used for testing Reverted ES Game List scraper - doesn't make sense to use `aliasMap.csv` with this scraper Not sure why this keeps getting added... I avoid staging it purposefully. Removed. Scummvm: Changes to generate a ROM folder.svm/ as <game/> launcher instead of folder. (Gemba#35) * Scummvm: Changes to generate a ROM `folder.svm/` as `<game/>` launcher instead of folder. update README Update from RetroPie Project (2024-02-22) cf. RetroPie/EmulationStation#866 Cpp Std 17 Add new platforms (Gemba#37) Updated platforms_idmap.csv and peas.json Update docs: - Removed passages about creating a symlink on RetroPie (now part of the scriptmodule). - Edit paragraph about bash_completion on RetroPie Fix Gemba#38 (Gemba#43) Plus cornercase solved: When default ES inputFolder is symlinked from /home/pi/RetroPie/roms to /home/pi/roms f.i. and user provides from that symlink downwards rom files on CLI. Version 3.10.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added quite a few new platforms, these are based off https://github.com/XargonWan/RetroDECK/blob/main/es-configs/es_systems.xml and No-Intro DATs.