forked from detain/skyscraper
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rel 3.10.0 #26
Merged
Merged
Rel 3.10.0 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plus: - qmake: user defined install path - doc: minor enhancements
…t converted to larger type
retrobit
pushed a commit
to retrobit/skyscraper
that referenced
this pull request
Mar 4, 2024
* simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type
retrobit
pushed a commit
to retrobit/skyscraper
that referenced
this pull request
Mar 4, 2024
* simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type
retrobit
added a commit
to retrobit/skyscraper
that referenced
this pull request
Mar 4, 2024
Don't build/install Skyscraper after dev container build Configure git for dev container Updated `devcontainer.json` and `.devcontainer/Dockerfile` Updated `.devcontainer` and added `build.sh` for easy building Added `postCreateCommand.sh` for additional Dev Container configuration Generalized ROM directory created in `postCreateCommand.sh` away from VSCode Moved `postCreateCommand.sh` to `.devcontainer` `postCreateCommand.sh` - Commented-out troublesome default `git` configuration; kept as still useful at developer's discretion platform psp: added *.chd Rel 3.10.0 (Gemba#26) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type Rel 3.10.0 (Gemba#27) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type * Version 3.10.0 Fix issue 28 (Gemba#32) * simplified code with predefined function * Fix Gemba#28 Fix cont. integration workflo (Gemba#33) * update package index before install postCreateCommand.sh - Commented-out troublesome default configuration; still useful at developer's discretion
retrobit
added a commit
to retrobit/skyscraper
that referenced
this pull request
Mar 4, 2024
Updated `aliasMap.csv` comments platform psp: added *.chd Dev Container support w/Dockerfile (Gemba#23) Co-authored-by: retrobit <6226450+retrobit@users.noreply.github.com> Rel 3.10.0 (Gemba#26) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type Rel 3.10.0 (Gemba#27) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type * Version 3.10.0 Fix issue 28 (Gemba#32) * simplified code with predefined function * Fix Gemba#28 Fix cont. integration workflo (Gemba#33) * update package index before install Being pedantic/consistent Pedantic/clarifying/consistent Removed file used for testing Reverted ES Game List scraper - doesn't make sense to use `aliasMap.csv` with this scraper Not sure why this keeps getting added... I avoid staging it purposefully. Removed. Scummvm: Changes to generate a ROM folder.svm/ as <game/> launcher instead of folder. (Gemba#35) * Scummvm: Changes to generate a ROM `folder.svm/` as `<game/>` launcher instead of folder. update README Update from RetroPie Project (2024-02-22) cf. RetroPie/EmulationStation#866 Cpp Std 17 Add new platforms (Gemba#37) Updated platforms_idmap.csv and peas.json Update docs: - Removed passages about creating a symlink on RetroPie (now part of the scriptmodule). - Edit paragraph about bash_completion on RetroPie Fix Gemba#38 (Gemba#43) Plus cornercase solved: When default ES inputFolder is symlinked from /home/pi/RetroPie/roms to /home/pi/roms f.i. and user provides from that symlink downwards rom files on CLI. Version 3.10.2
retrobit
added a commit
to retrobit/skyscraper
that referenced
this pull request
Mar 4, 2024
Updated `aliasMap.csv` comments platform psp: added *.chd Dev Container support w/Dockerfile (Gemba#23) Co-authored-by: retrobit <6226450+retrobit@users.noreply.github.com> Rel 3.10.0 (Gemba#26) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type Rel 3.10.0 (Gemba#27) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type * Version 3.10.0 Fix issue 28 (Gemba#32) * simplified code with predefined function * Fix Gemba#28 Fix cont. integration workflo (Gemba#33) * update package index before install Being pedantic/consistent Pedantic/clarifying/consistent Removed file used for testing Reverted ES Game List scraper - doesn't make sense to use `aliasMap.csv` with this scraper Not sure why this keeps getting added... I avoid staging it purposefully. Removed. Scummvm: Changes to generate a ROM folder.svm/ as <game/> launcher instead of folder. (Gemba#35) * Scummvm: Changes to generate a ROM `folder.svm/` as `<game/>` launcher instead of folder. update README Update from RetroPie Project (2024-02-22) cf. RetroPie/EmulationStation#866 Cpp Std 17 Add new platforms (Gemba#37) Updated platforms_idmap.csv and peas.json Update docs: - Removed passages about creating a symlink on RetroPie (now part of the scriptmodule). - Edit paragraph about bash_completion on RetroPie Fix Gemba#38 (Gemba#43) Plus cornercase solved: When default ES inputFolder is symlinked from /home/pi/RetroPie/roms to /home/pi/roms f.i. and user provides from that symlink downwards rom files on CLI. Version 3.10.2
retrobit
added a commit
to retrobit/skyscraper
that referenced
this pull request
Mar 4, 2024
Don't build/install Skyscraper after dev container build Configure git for dev container Updated `devcontainer.json` and `.devcontainer/Dockerfile` Updated `.devcontainer` and added `build.sh` for easy building Added `postCreateCommand.sh` for additional Dev Container configuration Generalized ROM directory created in `postCreateCommand.sh` away from VSCode Moved `postCreateCommand.sh` to `.devcontainer` `postCreateCommand.sh` - Commented-out troublesome default `git` configuration; kept as still useful at developer's discretion platform psp: added *.chd Rel 3.10.0 (Gemba#26) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type Rel 3.10.0 (Gemba#27) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type * Version 3.10.0 Fix issue 28 (Gemba#32) * simplified code with predefined function * Fix Gemba#28 Fix cont. integration workflo (Gemba#33) * update package index before install postCreateCommand.sh - Commented-out troublesome default configuration; still useful at developer's discretion
retrobit
added a commit
to retrobit/skyscraper
that referenced
this pull request
Mar 4, 2024
Updated `aliasMap.csv` comments platform psp: added *.chd Dev Container support w/Dockerfile (Gemba#23) Co-authored-by: retrobit <6226450+retrobit@users.noreply.github.com> Rel 3.10.0 (Gemba#26) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type Rel 3.10.0 (Gemba#27) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type * Version 3.10.0 Fix issue 28 (Gemba#32) * simplified code with predefined function * Fix Gemba#28 Fix cont. integration workflo (Gemba#33) * update package index before install Being pedantic/consistent Pedantic/clarifying/consistent Removed file used for testing Reverted ES Game List scraper - doesn't make sense to use `aliasMap.csv` with this scraper Not sure why this keeps getting added... I avoid staging it purposefully. Removed. Scummvm: Changes to generate a ROM folder.svm/ as <game/> launcher instead of folder. (Gemba#35) * Scummvm: Changes to generate a ROM `folder.svm/` as `<game/>` launcher instead of folder. update README Update from RetroPie Project (2024-02-22) cf. RetroPie/EmulationStation#866 Cpp Std 17 Add new platforms (Gemba#37) Updated platforms_idmap.csv and peas.json Update docs: - Removed passages about creating a symlink on RetroPie (now part of the scriptmodule). - Edit paragraph about bash_completion on RetroPie Fix Gemba#38 (Gemba#43) Plus cornercase solved: When default ES inputFolder is symlinked from /home/pi/RetroPie/roms to /home/pi/roms f.i. and user provides from that symlink downwards rom files on CLI. Version 3.10.2
retrobit
added a commit
to retrobit/skyscraper
that referenced
this pull request
Mar 4, 2024
Updated `aliasMap.csv` comments platform psp: added *.chd Dev Container support w/Dockerfile (Gemba#23) Co-authored-by: retrobit <6226450+retrobit@users.noreply.github.com> Rel 3.10.0 (Gemba#26) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type Rel 3.10.0 (Gemba#27) * simplified bash completion with built-in/provided functions... plus: - qmake: user defined install path - doc: minor enhancements * Prevention of very unlikely arithmetic overflow: Multiplication result converted to larger type * Version 3.10.0 Fix issue 28 (Gemba#32) * simplified code with predefined function * Fix Gemba#28 Fix cont. integration workflo (Gemba#33) * update package index before install Being pedantic/consistent Pedantic/clarifying/consistent Removed file used for testing Reverted ES Game List scraper - doesn't make sense to use `aliasMap.csv` with this scraper Not sure why this keeps getting added... I avoid staging it purposefully. Removed. Scummvm: Changes to generate a ROM folder.svm/ as <game/> launcher instead of folder. (Gemba#35) * Scummvm: Changes to generate a ROM `folder.svm/` as `<game/>` launcher instead of folder. update README Update from RetroPie Project (2024-02-22) cf. RetroPie/EmulationStation#866 Cpp Std 17 Add new platforms (Gemba#37) Updated platforms_idmap.csv and peas.json Update docs: - Removed passages about creating a symlink on RetroPie (now part of the scriptmodule). - Edit paragraph about bash_completion on RetroPie Fix Gemba#38 (Gemba#43) Plus cornercase solved: When default ES inputFolder is symlinked from /home/pi/RetroPie/roms to /home/pi/roms f.i. and user provides from that symlink downwards rom files on CLI. Version 3.10.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.