Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make host customizeable through an environment variable #21

Closed
pajlada opened this issue Oct 17, 2018 · 1 comment
Closed

Make host customizeable through an environment variable #21

pajlada opened this issue Oct 17, 2018 · 1 comment

Comments

@pajlada
Copy link
Collaborator

pajlada commented Oct 17, 2018

Right now, the host is :3333 by default, as set in https://github.com/gempir/relaybroker/blob/master/server.go#L17
Changing that requires you to modify the source code, but it would be preferable if you could change it with an environment variable similar to BROKERPASS. Maybe BROKERHOST?
@gempir
Copy link
Owner

gempir commented Oct 17, 2018 •
edited
Loading

Thought this was already implemented. Yes this should definitely be implemented.

The Dockerfile should be corrected aswell once this is implemented.

@pajlada pajlada mentioned this issue Oct 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pajlada @gempir