Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect class definition string #17

Closed
ericwinger opened this issue Mar 21, 2018 · 3 comments
Closed

incorrect class definition string #17

ericwinger opened this issue Mar 21, 2018 · 3 comments

Comments

@ericwinger
Copy link
Member

Sending method classCreationTemplateForClass:hybridBrowser: to RowanDefinitionService results in this class definition string, however this method does not appear to be implemented in Rowan:

Object rwSubclass: 'RowanDefinitionService'
instVarNames: #( definition)
classVars: #()
classInstVars: #()
poolDictionaries: #()
inDictionary: ''
category: 'Rowan-Services'
options: #()
@dalehenrich
Copy link
Member

ah ... I removed the inDictionary: arg from the actual messages and missed changing the template ... poor test coverage ..

@ericwinger
Copy link
Member Author

No problem. I'll pick the change up tomorrow.

fyi - I'm not going to test your new readme instructions tonight. I'll test it tomorrow.

dalehenrich added a commit that referenced this issue Mar 22, 2018
@dalehenrich
Issue #17 fix
8e76b62 
Remove `inDictionary:` from the class creation templates. Add 2 new tests:
  RwHybridBrowserToolTest>>testHybridClassCreationWithClassCreationTemplateA
  RwHybridBrowserToolTest>>testHybridClassCreationWithClassCreationTemplateB

to fill the gap in test coverage ... there were a few other tweaks needed for the templates to be correct ... mainly in the area of using hybrid naming when it's not appropriate and expand the options for creating templaces of variable and bytes classes.

tests are green:

  87 run, 86 passes, 1 expected defects, 0 failures, 0 errors, 0 unexpected passes
@dalehenrich
Copy link
Member

I'll be in the office tomorrow, so that'll be a good time to try out something new ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dalehenrich @ericwinger