New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review mf_needs_review subset - possible obsoletions #16166
Comments
I'm holding off on obsoleting the two tRNA terms. A merge might be more appropriate; let me think for a bit; |
Yes, I remember |
FMN reductase activity' http://purl.obolibrary.org/obo/GO_0008752 has 29 annotations EC 1.5.1.29
carotene 7,8-desaturase activity' http://purl.obolibrary.org/obo/GO_0016719 3 annotations (1 IEA, 1 IDA, and 1 IBA; gene product name is the name of the new EC 'dihydroorotate oxidase activity' http://purl.obolibrary.org/obo/GO_0004158 38 annotations (16 IEA) |
'hydroxynitrilase activity' http://purl.obolibrary.org/obo/GO_0047606; no annotations
EC:1.5.3.11, transferred to 5 different EC ids
Owners of annotations need to figure out which of these is a more appropriate term |
So for the ones with no comment it is hard to know why it is in this slim |
clavaminate synthase activity' http://purl.obolibrary.org/obo/GO_0033758 EC:1.14.11.21 cobyrinic acid a,c-diamide synthase activity http://www.ontobee.org/ontology/GO?iri=http://purl.obolibrary.org/obo/GO_0042242 |
@pgaudet , if I can fix some immediately, do you want me to just remove them as a member of the for review slim? Let me know (I will continue doing the analysis and put results in this ticket). |
Hi @hdrabkin OK with you? |
'alcohol dehydrogenase (acceptor) activity' http://purl.obolibrary.org/obo/GO_0018468 -- |
@pgaudet: Sure; this ticket suffices to my being able to be tracking them. As I make final fixes I can mark them resolved. |
It would be optimal that if we are retaining these terms, a Rhea xref could be added to the generic reaction if it exists. Otherwise we should make a note that we need to request the reaction from Rhea. |
thalianol synthase activity' http://purl.obolibrary.org/obo/GO_0051746; add EC 5.4.99.31; RHEA:26163 DONE Clavaminate synthase. EC 1.14.11.21; catalysis of 3 reactions This is how EC has it as does GO. |
fixed parents, fixed xrefs fixes #16166
Hello @hdrabkin
At a receont ontology call we elected you to review the terms in the 'mf_needs_review' slim (and then presumably retiring that slim).
The following have a comment that the obsoletion is planned:
FMN reductase activity' http://purl.obolibrary.org/obo/GO_0008752 DONE IN #16166
'carotene 7,8-desaturase activity' http://purl.obolibrary.org/obo/GO_0016719 DONE in #2050
'dihydroorotate oxidase activity' http://purl.obolibrary.org/obo/GO_0004158 obsoleted in #23789
'hydroxynitrilase activity' http://purl.obolibrary.org/obo/GO_0047606 add RHEA xrefs and missing children
'polyamine oxidase activity' http://purl.obolibrary.org/obo/GO_0046592 branch improved in #24701
'tRNA adenylyltransferase activity' http://purl.obolibrary.org/obo/GO_0004810 DONE in #19854
Those have no comment:
'DNA-N1-methyladenine dioxygenase activity' http://purl.obolibrary.org/obo/GO_0043734
'alcohol dehydrogenase (acceptor) activity' http://purl.obolibrary.org/obo/GO_0018468 Merged (cannot find the ticket)
'amine dehydrogenase activity' http://purl.obolibrary.org/obo/GO_0030058 OK Has a RHEA
'aspartyl esterase activity' http://purl.obolibrary.org/obo/GO_0045330 ?????
'chondroitin ABC lyase activity' http://purl.obolibrary.org/obo/GO_0047486 Obsoleted in #24702
'clavaminate synthase activity' http://purl.obolibrary.org/obo/GO_0033758 OK Has a RHEA and an EC
'cobyrinic acid a,c-diamide synthase activity' http://purl.obolibrary.org/obo/GO_0042242 OK Has a RHEA and an EC
'dolichyl-phosphate-mannose-glycolipid alpha-mannosyltransferase activity' http://purl.obolibrary.org/obo/GO_0004584 Obsoleted in #14578
'gibberellin 20-oxidase activity' http://purl.obolibrary.org/obo/GO_0045544 ?? No RHEA, some TAIR annotations
'glutamin-(asparagin-)ase activity' http://purl.obolibrary.org/obo/GO_0050417 Could obsolete in favor of asparaginase activity and glutaminase activity (no annotations)
'linoleate diol synthase activity' http://purl.obolibrary.org/obo/GO_0033751 obsoleted in
#22050
'oxidosqualene cyclase activity' http://purl.obolibrary.org/obo/GO_0031559 OK grouping class
'polyamine oxidase activity' http://purl.obolibrary.org/obo/GO_0046592 branch improved in #24701
'protein-N-terminal glutamine amidohydrolase activity' http://purl.obolibrary.org/obo/GO_0070773 OK Has a RHEA and an EC
thalianol synthase activity' http://purl.obolibrary.org/obo/GO_0051746 OK Has a RHEA and an EC
Thanks, Pascale
'tRNA cytidylyltransferase activity' http://purl.obolibrary.org/obo/GO_0016437 Fixed in #19854
'trans-octaprenyltranstransferase activity' http://purl.obolibrary.org/obo/GO_0050347 Done in #23417
'trans-pentaprenyltranstransferase activity' http://purl.obolibrary.org/obo/GO_0048045 Obsoleted in #23202
The text was updated successfully, but these errors were encountered: