Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SGD has incomplete GPI #36

Closed
suzialeksander opened this issue Dec 4, 2018 · 11 comments
Closed

SGD has incomplete GPI #36

suzialeksander opened this issue Dec 4, 2018 · 11 comments
Assignees

Comments

@suzialeksander
Copy link

suzialeksander commented Dec 4, 2018

SGD is currently only providing UniProt in the GPI in the metadata--taken directly from protein2go upstream as a "stub". At the time, SGD was not currently using Noctua beyond basic experimentation and it was decided that the stub was more information than none. Now that SGD is giving Noctua more use, the obvious identifier issue has come up and needs to be fixed as we proceed with more serious annotation.

As an example, in the Noctua Form, eg "STE3 Scer” pops up with the UniProt ID instead of SGD ID, so the “search database” doesn’t work.

The potential fix in this case: GO can derive a GPI from some other file.

@kltm
Copy link
Member

kltm commented Dec 4, 2018

@cmungall Should we derive here or work with SGD to provide a better source for us?

@cmungall
Copy link
Member

cmungall commented Dec 4, 2018

I think right now we should remove the gpi entry from sgd.yaml. neo will fall back on the GAF. Which is good enough for a well-annotated genome for SGD.

After that we can try another solution. SGD provide a BGI for the Alliance, providing a GPI should not be hard and we can have some shared conversion code.

@suzialeksander
Copy link
Author

Sounds like there's a plan? Let me know if there's something SGD specifically needs to do. Thanks

kltm added a commit to geneontology/go-site that referenced this issue Dec 5, 2018
Remove confusing GPI entry as a workaround for geneontology/neo#36
@kltm
Copy link
Member

kltm commented Dec 5, 2018

@cmungall geneontology/go-site#953 correct?

@kltm
Copy link
Member

kltm commented Dec 12, 2018

Merged and waiting for effect over the weekend.

@suzialeksander
Copy link
Author

Update: No sgd Noctua gpad, but our existing annotations to Uniprot accessions are being rejected in the Form summary page (good I suppose) and SGD IDs are autofilling in. What steps do we need to take now to get a Noctua gpad?

@kltm
Copy link
Member

kltm commented Dec 21, 2018

Well, if the IDs are SGD, the next time the models are reduced to GPADs in the pipeline they should come out naturally (assuming everything else is okay).
If I'm missing the answer you're wanting, feel free to tag me and we can get some of the others to take a look at it.

@suzialeksander
Copy link
Author

next time the models are reduced to GPADs in the pipeline

This is a "daily/24h" occurrence or you mean the monthly release?

@kltm
Copy link
Member

kltm commented Dec 21, 2018

This is a daily occurrence, which should be completed sometime in the evening, every day. The pickup location is the snapshot set of URLs, but progress can be seen here:
https://build.geneontology.org/job/geneontology/job/pipeline/job/snapshot/

@suzialeksander
Copy link
Author

Thanks for the info, I'll bet we missed today's cutoff. We'll check it later. Thanks!

@suzialeksander
Copy link
Author

ah well it looks like this is fine now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants