-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable relations across models #592
Comments
cool sounds a bit like pathway collages! https://www.ncbi.nlm.nih.gov/pubmed/?term=27964719 |
(did you mean to say biological process, or MF?) There are perhaps some sub-use cases here it may help to enumerate as they may require different approaches
I'm not sure if this precisely maps to curators ways of thinking, it would be good to make some concrete examples of where this is desired, with PMIDs. It's important to think about the meaning of these linkages. If the intent is that the semantics of an inter-model MF-MF link is the same as intra-model, then obviously they must be the same species (for non host-pathogen). But we have subtler cases, as we may have models at different levels of granularity or "prototypicality". In a single model we would not connect a neuronal process to a liver process, even if the same underlying modules are used (unless we were explicitly modeling some nervous system-liver interaction). I think we want to apply the same restrictions across models, and if you need an analogous model that deploys some of the same components then there would be a clone/copy operation. |
@cmungall when I wrote that, I was thinking of the MF - BP connection made in this model: http://noctua.geneontology.org/editor/graph/gomodel:5b91dbd100000506 (which I have used in my recent talks). Generally speaking I find MF-BP connections a little weird (seems like MF-MF where MFs may be part of different BPs would generally be more useful), but I see curators doing that often. I agree that it would be very useful to have some curator driven use cases spelled out here - ping @vanaukenk . The other use case emerging from my work on the Reactome import are the connections that they make between reactions (MFs) in different pathways. One reaction can be part of one pathway but be e.g. causally downstream of a reaction in a different pathway. As long as we separate pathways into different models (which I think is a good idea unless we want to end up with one giant one) we currently have no way of capturing those connections. I'd suggest splitting your bullet 3. into the curator use case and the researcher use case (and in fact putting the researcher use case into a different issue on a new project made specifically for end-users, not curators). I'd restate something like this: |
@goodb - thanks for adding this ticket. |
Ras-Raf to MAPK would be an interesting example. What do we do with the linking MFs? Are they part of more than one pathway? I think so. |
This is a functionality that Colin and Swiss-Prot curators would find very useful. |
@pgaudet Could you explain the use case for the SP curators in a little more detail here? Is it included in @cmungall 's list above, or is there something else going on? Cross-model linking is potentially a very "disruptive" change, so I'd like to understand if there are alternative paths rather than declaring it as a requirement upfront. Specifically, I'd like to understand the desired workflow or type of curation needed and then work backwards to what an appropriate architecture or tooling might look like (before getting to how much effort might be involved, priorities, etc.). |
The main idea is to modularize the models as biological units, so that we can "reuse" the modules in models of larger biological processes. This will reduce redundancy among models, avoid unnecessary curator work in re-creating the same module as part of different BPs, and ensure that updates to a module won't require manual updating in any larger model that refers to them. I will work with @pgaudet and the Swiss-Prot team to get some examples that illustrate what they want to do, and some visuals that might give us a starting point for discussion. |
Use case description:
As an example, a curator has a molecular function node in their model and they want to create a 'causally upstream of' edge between that node and a biological process node that already exists in another model.
Curator needs to be able to find the target node in the other model, create the edge, and be able to view content from the other model in the context of what they are working on.
The text was updated successfully, but these errors were encountered: