Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Term comments not present in go-plus.json #18

Closed
tonysawfordebi opened this issue Jan 9, 2017 · 3 comments · Fixed by #19
Closed

Term comments not present in go-plus.json #18

tonysawfordebi opened this issue Jan 9, 2017 · 3 comments · Fixed by #19

Comments

@tonysawfordebi
Copy link

As well as the issue (reported elsewhere) of the "is_obsolete" flag not being present in the JSON representation, I've also spotted that term comments are missing too.

cmungall added a commit that referenced this issue Jan 9, 2017
@cmungall
Copy link
Member

cmungall commented Jan 9, 2017

Both #17 and #19 are in 0.0.9 which has just been staged at mvncentral

if you want to experiment you can change the pom.xml for owltools. I'll do this sometime this week after which changes will propagate to http://purl.obolibrary.org/obo/go/extensions/go-plus.json

@dosumis
Copy link

dosumis commented Mar 10, 2017

I've just updated to the latest OWLtools, but using this, the complete set of meta keys is still:

{'definition', 'subsets', 'synonyms', 'xrefs'}

Compared to this for the released version of go-plus.json:

{'basicPropertyValues',
'comments',
'definition',
'deprecated',
'subsets',
'synonyms',
'xrefs'}

Does something still need to be done to propagate changes through to OWLtools? I need this working quite urgently for VFB.

Cheers,
David

cmungall added a commit to owlcollab/owltools that referenced this issue Mar 10, 2017
@cmungall
Copy link
Member

You can always do a mvn build from this repo then run ogger script in this repo to use the latest from master.

Or make a PR to that updates the pom.xml in owltools to use the latest mvncentral version of this lib (this can be seen on the badge in the README.md in this repo). My latest commit (linked here) does this, so you should be good with a new owltools build for now, but it may lag again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants