Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References associated with taxon constraints are missing from go-plus.json #22

Open
tonysawfordebi opened this issue Mar 8, 2017 · 3 comments

Comments

@tonysawfordebi
Copy link

References that are associated with taxon constraints, and which are visible in go-plus.obo, are not finding their way into go-plus.json

A couple of examples from go-plus.obo:

[Term]
id: GO:0045271
name: respiratory chain complex I
...
relationship: never_in_taxon NCBITaxon:4896 {id="GOTAX:0000525", source="PMID:21597881"} ! Schizosaccharomyces pombe
relationship: never_in_taxon NCBITaxon:4932 {id="GOTAX:0000524", source="PMID:21597881"} ! Saccharomyces cerevisiae

[Term]
id: GO:0019819
name: P1 peroxisome
...
relationship: only_in_taxon NCBITaxon:4952 {id="GOTAX:0000526", source="PMID:10629216", source="PMID:14504266"} ! Yarrowia lipolytica

@cmungall
Copy link
Member

cmungall commented Mar 10, 2017 via email

@tonysawfordebi
Copy link
Author

Actually, I did understand why o_i_t and n_i_t were represented differently, but that wasn't my question. Indeed, I didn't actually ask a question, but made an observation ;)

The lack of the references associated with the taxon constraints is now the only difference between the output that my new obograph parser generates and that from my current owltools-based lash-up, so if there was a way to get those into the JSON, then everything (as far as my use case is concerned) would be perfect, and I could switch over to consuming go-plus.json, which would be A Good Thing.

@cmungall
Copy link
Member

oh, I should really read comments before replying! Yes you quite clearly said references. But hopefully my pedagogic excursion will be of use to anyone else puzzled by the TC representation.

so the simplest thing would be to include annotations on annotation assertion axioms (which should be done in any case), giving you a direct analog to the OWL.

I still think we should eventually move away from encoding the negated ones as annotations, but I will give plenty warning before switching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants